* [PATCH] Remove __init attribute for two functions.
@ 2007-11-16 6:49 Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDC9A06AB-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Zhang, Xiantao @ 2007-11-16 6:49 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
Remove __init attributes for kvm_init_debug and kvm_init_msr_list, since
their callers are not declared with __init. It maybe introduce prolems,
once kvm is built-in while kvm-intel or kvm-amd is built as module.
Thanks
Xiantao
[-- Attachment #2: 0003-Remove-__init-attributes-for-kvm_init_debug-and-kvm_.patch --]
[-- Type: application/octet-stream, Size: 1160 bytes --]
From 0ced2efb96413a03a65d0e7f55fb692e75b9e0cf Mon Sep 17 00:00:00 2001
From: Zhang Xiantao <xiantao.zhang@intel.com>
Date: Fri, 16 Nov 2007 14:38:21 +0800
Subject: [PATCH] Remove __init attributes for kvm_init_debug and kvm_init_msr_list,
since their callers are not declared with __init.
Signed-off-by: Zhang Xiantao <xiantao.zhang@intel.com>
---
drivers/kvm/kvm_main.c | 2 +-
drivers/kvm/x86.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
index 84eec47..1930641 100644
--- a/drivers/kvm/kvm_main.c
+++ b/drivers/kvm/kvm_main.c
@@ -1303,7 +1303,7 @@ static u64 stat_get(void *_offset)
DEFINE_SIMPLE_ATTRIBUTE(stat_fops, stat_get, NULL, "%llu\n");
-static __init void kvm_init_debug(void)
+static void kvm_init_debug(void)
{
struct kvm_stats_debugfs_item *p;
diff --git a/drivers/kvm/x86.c b/drivers/kvm/x86.c
index 375d36f..a5347ea 100644
--- a/drivers/kvm/x86.c
+++ b/drivers/kvm/x86.c
@@ -1080,7 +1080,7 @@ out:
return r;
}
-static __init void kvm_init_msr_list(void)
+static void kvm_init_msr_list(void)
{
u32 dummy[2];
unsigned i, j;
--
1.5.0.5
[-- Attachment #3: Type: text/plain, Size: 228 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
[-- Attachment #4: Type: text/plain, Size: 186 bytes --]
_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove __init attribute for two functions.
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDC9A06AB-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
@ 2007-11-18 11:11 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2007-11-18 11:11 UTC (permalink / raw)
To: Zhang, Xiantao; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
Zhang, Xiantao wrote:
> Remove __init attributes for kvm_init_debug and kvm_init_msr_list, since
> their callers are not declared with __init. It maybe introduce prolems,
> once kvm is built-in while kvm-intel or kvm-amd is built as module.
>
Applied, thanks. We will want to redo __init and __exit support one day.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-18 11:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-16 6:49 [PATCH] Remove __init attribute for two functions Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDC9A06AB-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-18 11:11 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox