public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] 0/3 MMU code split
@ 2007-11-19  5:35 Zhang, Xiantao
       [not found] ` <42DFA526FC41B1429CE7279EF83C6BDC9A0A7C-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Zhang, Xiantao @ 2007-11-19  5:35 UTC (permalink / raw)
  To: Avi Kivity; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

Hi Avi,
Considering your comments,I refined the patch, and use kvm->memslots to
caculate the nr_mmu_pagas every time.   
Patch [1/3] Move kvm_vcpu_iotcl_get_dirty_log implementation into arch,
and still keep the interface in common.
Patch [2/3] Move kvm_mmu init and exit functionality to arch. 
Patch [3/3] Add the hook kvm_arch_set_memory_region.  In this patch,
introduce a function kvm_caculate_mmu_pages to compute mmu pages in
total, once memory region changes.

Xiantao

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] 0/3 MMU code split
       [not found] ` <42DFA526FC41B1429CE7279EF83C6BDC9A0A7C-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
@ 2007-11-19 12:51   ` Avi Kivity
  0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2007-11-19 12:51 UTC (permalink / raw)
  To: Zhang, Xiantao; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

Zhang, Xiantao wrote:
> Hi Avi,
> Considering your comments,I refined the patch, and use kvm->memslots to
> caculate the nr_mmu_pagas every time.   
> Patch [1/3] Move kvm_vcpu_iotcl_get_dirty_log implementation into arch,
> and still keep the interface in common.
> Patch [2/3] Move kvm_mmu init and exit functionality to arch. 
>   

First two applied (missing a signoff on the first!).

> Patch [3/3] Add the hook kvm_arch_set_memory_region.  In this patch,
> introduce a function kvm_caculate_mmu_pages to compute mmu pages in
> total, once memory region changes.
>   

Please split this into two.  First part makes the real changes 
(kvm_calculate_mmu_changes) and the second part does the movement.  This 
makes it much easier to review and bisect.

Also, please send patches using git-send-email, that way the patches 
show inline and it is easier to review and comment.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-11-19 12:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-19  5:35 [PATCH] 0/3 MMU code split Zhang, Xiantao
     [not found] ` <42DFA526FC41B1429CE7279EF83C6BDC9A0A7C-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-19 12:51   ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox