From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] 0/3 MMU code split Date: Mon, 19 Nov 2007 14:51:55 +0200 Message-ID: <474186EB.4090705@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDC9A0A7C@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC9A0A7C-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Zhang, Xiantao wrote: > Hi Avi, > Considering your comments,I refined the patch, and use kvm->memslots to > caculate the nr_mmu_pagas every time. > Patch [1/3] Move kvm_vcpu_iotcl_get_dirty_log implementation into arch, > and still keep the interface in common. > Patch [2/3] Move kvm_mmu init and exit functionality to arch. > First two applied (missing a signoff on the first!). > Patch [3/3] Add the hook kvm_arch_set_memory_region. In this patch, > introduce a function kvm_caculate_mmu_pages to compute mmu pages in > total, once memory region changes. > Please split this into two. First part makes the real changes (kvm_calculate_mmu_changes) and the second part does the movement. This makes it much easier to review and bisect. Also, please send patches using git-send-email, that way the patches show inline and it is easier to review and comment. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/