From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [PATCH][1/3] Move kvm_vcpu_iotcl_get_dirty_log to arch Date: Mon, 19 Nov 2007 15:59:41 +0100 Message-ID: <4741A4DD.5020503@de.ibm.com> References: <42DFA526FC41B1429CE7279EF83C6BDC9A0A7D@pdsmsx415.ccr.corp.intel.com> <4741A011.2080405@de.ibm.com> <4741A322.8040201@qumranet.com> <4741A3FE.70908@de.ibm.com> Reply-To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: carsteno-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, Christian Ehrhardt , Hollis Blanchard , kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Avi Kivity , "Zhang, Xiantao" To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <4741A3FE.70908-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carsten Otte wrote: > Yea, I agree that it would make sense in case it works for power too. We > could have an > #ifdef CONFIG_ARCH_S390 > return cool_big_iron_get_dirty_log(args); > #endif > at the beginning of that function. It would'nt hurt readability too much. Stupid suggestion. We could outsource the #ifdef to the caller, that would be much cleaner. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/