From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][RFC] Struct kvm split Date: Mon, 19 Nov 2007 17:25:55 +0200 Message-ID: <4741AB03.6090008@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDC9A0C2B@pdsmsx415.ccr.corp.intel.com> <47419B7D.2060200@de.ibm.com> <42DFA526FC41B1429CE7279EF83C6BDC9A0C6A@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, carsteno-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, Hollis Blanchard To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC9A0C6A-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Zhang, Xiantao wrote: > Carsten Otte wrote: > = >> Zhang, Xiantao wrote: >> = >>> Based on privious discussion, I made this patch to split struct kvm. >>> In this patch, strcut kvm only holds common fields, and struct >>> kvm_x86 will keep x86-specific fields. In this way, struct kvm will >>> be a sub-filed in struct kvm_x86, and we can use to_kvm_x86 to get >>> kvm_x86 from struct kvm. It is very similar with current to_vmx >>> approach for getting struct vmx from struct kvm_vcpu. This is a >>> rough split based on this idea. Any comments are welcome! >>> = >> Patch #2 does'nt apply for me, on top of #1 on today's kvm.git: >> cotte@kvm:~/kvm$ quilt push >> Wende Patch 0002-Move-strcut-kvm_x86_ops-defintion-to-x86.h.patch an >> (Stripping trailing CRs from patch.) >> patching file drivers/kvm/kvm.h >> (Stripping trailing CRs from patch.) >> patching file drivers/kvm/x86.h >> patch: **** malformed patch at line 169: int >> kvm_mmu_page_fault(struct kvm_vcpu *vcpu, gva_t gva, u32 error_code); >> >> Patch 0002-Move-strcut-kvm_x86_ops-defintion-to-x86.h.patch l=E4sst sich >> nicht anwenden (erzwingen mit -f) >> = > > Hi, Carsten > The first 5 patches have been checked into upstream tree. Maybe you = can have a pull. For the sixth one, it can be applied on the latest commi= ts. = > Xiantao > = They only applied after much massaging by me (I forgot to complain, sorry). Please use git-send-email, it's much better at getting the patches out = undamaged. -- = error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/