From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Add the hook kvm_arch_set_memory region to hold mmu-specific changes Date: Mon, 19 Nov 2007 17:30:23 +0200 Message-ID: <4741AC0F.8070502@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDC9A0A7F@pdsmsx415.ccr.corp.intel.com> <4741A1FC.2080407@de.ibm.com> <42DFA526FC41B1429CE7279EF83C6BDC9A0C66@pdsmsx415.ccr.corp.intel.com> <4741A608.2000204@de.ibm.com> <4741A68D.9000003@qumranet.com> <42DFA526FC41B1429CE7279EF83C6BDC9A0C6C@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, carsteno-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC9A0C6C-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Zhang, Xiantao wrote: > Avi Kivity wrote: > >> Carsten Otte wrote: >> >>> Zhang, Xiantao wrote: >>> >>>> User-allocation should be what we are heading. But considering >>>> compatibility with old user-space support, I think kernel-allocation >>>> approach should exist for a long time. >>>> >>> That's right. This is why I would prefer to have the corresponding >>> code out of kvm_main.c: it may exist for a long time for x86. >>> >>> >>>> I think we don't need to consider >>>> this case now. Once the kernel-allocation approach is abandoned in >>>> future, as you say, we can move them all into x86. >>>> >>> I'd rather prefer to move it upfront. Otherwise, I'd have to consider >>> that case for s390 as long as it remains in common. At least I'd have >>> to make sure it does'nt get used on s390 using an if() or #ifdef. >>> >> I agree, other archs shouldn't have to suffer. >> > > So, now we move the whole thing(__kvm_set_memory_region) into arch ? :) > Xiantao > It's fairly generic. Only the if (!user_alloc) parts need to move. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/