Re: [PATCH] KVM Portability : Spliting kvm_set_memory_region.

[Carsten Otte <cotte-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>]

Zhang, Xiantao wrote:
> From: Zhang Xiantao <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Date: Tue, 20 Nov 2007 16:25:04 +0800
> Subject: [PATCH] KVM Portability : Spliting kvm_set_memory_region.
> Moving !user_alloc case to kvm_arch to avoid unnecessary
> code logic in non-x86 platform.
> Signed-off-by: Zhang Xiantao <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
>  drivers/kvm/kvm.h      |    4 +++
>  drivers/kvm/kvm_main.c |   38 ++++-------------------------------
>  drivers/kvm/x86.c      |   51
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 60 insertions(+), 33 deletions(-)

I don't think we'll want the rmap part in common for s390, but I am 
not sure just yet. If it turns out to be the case, I might submit an 
add on patch that moves it to arch on day. Other then that, this split 
looks good to me. Well done, Xiantao!

Acked-by: Carsten Otte <cotte-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/