From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [PATCH] KVM Portability : Spliting kvm_set_memory_region. Date: Tue, 20 Nov 2007 13:40:25 +0100 Message-ID: <4742D5B9.4060206@de.ibm.com> References: <42DFA526FC41B1429CE7279EF83C6BDC9A0FD7@pdsmsx415.ccr.corp.intel.com> Reply-To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Hollis Blanchard , Avi Kivity To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC9A0FD7-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Zhang, Xiantao wrote: > From: Zhang Xiantao > Date: Tue, 20 Nov 2007 16:25:04 +0800 > Subject: [PATCH] KVM Portability : Spliting kvm_set_memory_region. > Moving !user_alloc case to kvm_arch to avoid unnecessary > code logic in non-x86 platform. > Signed-off-by: Zhang Xiantao > --- > drivers/kvm/kvm.h | 4 +++ > drivers/kvm/kvm_main.c | 38 ++++------------------------------- > drivers/kvm/x86.c | 51 > ++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 60 insertions(+), 33 deletions(-) I don't think we'll want the rmap part in common for s390, but I am not sure just yet. If it turns out to be the case, I might submit an add on patch that moves it to arch on day. Other then that, this split looks good to me. Well done, Xiantao! Acked-by: Carsten Otte ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/