From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Carsten Otte <cotte-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
"Zhang,
Xiantao" <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hollis Blanchard
<hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Subject: Re: RFC/patch 2/2: remove irq.h include in kvm_main.c
Date: Thu, 22 Nov 2007 18:37:13 +0200 [thread overview]
Message-ID: <4745B039.20108@qumranet.com> (raw)
In-Reply-To: <1195749032.22845.10.camel-WIxn4w2hgUz3YA32ykw5MLlKpX0K8NHHQQ4Iyu8u01E@public.gmane.org>
Carsten Otte wrote:
> This patch removes the include of "irq.h" in kvm_main.c, s390 does not
> have irqs. For that, kvm_cpu_has_interrupt becomes an architecutre
> specific function which can check for external or I/O interrupts on s390
> and for irqs on x86 and others. In order to clarify wording, the
> function defined by irq.h has been renamed to kvm_cpu_has_irq.
>
I generally understand "irq" to mean the interrupt request line, and
"interrupt" to mean a vectored interrupt (post interrupt controller).
In those terms the naming in correct. However I'm not at all certain
this naming convention is generally accepted.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2007-11-22 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 16:24 RFC/patch 1/2: remove desc.h include in kvm_main.c Carsten Otte
[not found] ` <1195748641.22845.3.camel-WIxn4w2hgUz3YA32ykw5MLlKpX0K8NHHQQ4Iyu8u01E@public.gmane.org>
2007-11-22 16:30 ` RFC/patch 2/2: remove irq.h " Carsten Otte
[not found] ` <1195749032.22845.10.camel-WIxn4w2hgUz3YA32ykw5MLlKpX0K8NHHQQ4Iyu8u01E@public.gmane.org>
2007-11-22 16:37 ` Avi Kivity [this message]
[not found] ` <4745B039.20108-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-22 16:42 ` Cornelia Huck
[not found] ` <20071122174230.52d6f4bd-XQvu0L+U/CiXI4yAdoq52KN5r0PSdgG1zG2AekJRRhI@public.gmane.org>
2007-11-22 16:45 ` Avi Kivity
[not found] ` <4745B217.9080202-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-22 16:49 ` Avi Kivity
2007-11-22 17:20 ` Cornelia Huck
2007-11-22 16:47 ` Carsten Otte
[not found] ` <4745B2A8.9040702-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-11-22 16:52 ` Avi Kivity
2007-11-22 16:34 ` RFC/patch 1/2: remove desc.h " Avi Kivity
2007-11-22 23:11 ` Zhang, Xiantao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4745B039.20108@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=cotte-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox