From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: RFC/patch 2/2: remove irq.h include in kvm_main.c Date: Thu, 22 Nov 2007 18:49:53 +0200 Message-ID: <4745B331.8000108@qumranet.com> References: <1195748641.22845.3.camel@cotte.boeblingen.de.ibm.com> <1195749032.22845.10.camel@cotte.boeblingen.de.ibm.com> <4745B039.20108@qumranet.com> <20071122174230.52d6f4bd@gondolin.boeblingen.de.ibm.com> <4745B217.9080202@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Carsten Otte , Hollis Blanchard , "Zhang, Xiantao" To: Cornelia Huck Return-path: In-Reply-To: <4745B217.9080202-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > Cornelia Huck wrote: >>> Carsten Otte wrote: >>> >>>> This patch removes the include of "irq.h" in kvm_main.c, s390 does not >>>> have irqs. For that, kvm_cpu_has_interrupt becomes an architecutre >>>> specific function which can check for external or I/O interrupts on >>>> s390 >>>> and for irqs on x86 and others. In order to clarify wording, the >>>> function defined by irq.h has been renamed to kvm_cpu_has_irq. >>>> >>> I generally understand "irq" to mean the interrupt request line, and >>> "interrupt" to mean a vectored interrupt (post interrupt >>> controller). In those terms the naming in correct. However I'm not >>> at all certain this naming convention is generally accepted. >>> >> >> Well, at least IO-Interrupts on s390 don't really fit this model from my >> point of view. (In fact, we can even get IO-Interrupts that are not >> associated with any (channel) device at all). >> > > Oh, I agree about the removal, just wondering about the name change. > > Sorry, I misunderstood what you were saying. Anyway I'm not at all sure that the way I understand the names "irq" and "interrupt" is correct. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/