From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: RFC/patch 2/2: remove irq.h include in kvm_main.c Date: Thu, 22 Nov 2007 18:52:43 +0200 Message-ID: <4745B3DB.3000300@qumranet.com> References: <1195748641.22845.3.camel@cotte.boeblingen.de.ibm.com> <1195749032.22845.10.camel@cotte.boeblingen.de.ibm.com> <4745B039.20108@qumranet.com> <4745B2A8.9040702@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "Zhang, Xiantao" , Hollis Blanchard To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <4745B2A8.9040702-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carsten Otte wrote: > Avi Kivity wrote: >> I generally understand "irq" to mean the interrupt request line, and >> "interrupt" to mean a vectored interrupt (post interrupt >> controller). In those terms the naming in correct. However I'm not >> at all certain this naming convention is generally accepted. > I think on s390 we'll have > > kvm_s390_vcpu_has_extint() > kvm_s390_vcpu_has_ioint() > and maybe > kvm_s390_vcpu_has_machine_check() > > and kvm_arch_vcpu_has_interrupt() will check if any of above is > pending. It would be great if the function names would clearly > identify that one is the general portable "cpu needs to run an > interrupt handler of whatever sort" and the other one is "we have a > vectored interrupt to deliver" on x86 as well. If you'd like to keep > the wording as is, I'll send a patch that just adds the > kvm_arch_cpu_has_interrupt wrapper. What I'd like is to find out what the generally accepted terminology is, and conform to that. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/