From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Add the arg "module" for kvm_arch_init Date: Sun, 25 Nov 2007 11:43:00 +0200 Message-ID: <474943A4.507@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDC9E752C@pdsmsx415.ccr.corp.intel.com><200711230919.38608.borntraeger@de.ibm.com><42DFA526FC41B1429CE7279EF83C6BDC9E773F@pdsmsx415.ccr.corp.intel.com> <47469EAF.8010301@de.ibm.com> <42DFA526FC41B1429CE7279EF83C6BDC9E77AA@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, borntrae-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC9E77AA-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Zhang, Xiantao wrote: > Carsten Otte wrote: > >> Zhang, Xiantao wrote: >> >>> No, THIS_MODULE just stands for itself. But for IA64, we need another >>> module, and it will register some information to kvm module. So, we >>> have to keep it. >>> >> That answer confuses me. kvm_arch_init() for ia64 will reside in >> kvm.ko just like kvm_init(), right? >> So THIS_MODULE will be the same in kvm_arch_init() and kvm_init(). So >> which module are you giving as argument? >> > > Sorry for confusing you. In KVM/IA64 architecture, we have a separate > module called vmm module to handle mmu and cpu virtualization. It is not > related to kvm_arch, and will be relocated by kvm.ko when it is > initilized. So, we have to get some information through its > registeration when it calls kvm_init. Certaninly, this information > should be transftered to kvm_arch_init, and handled by ia64-specific > code. Is it clear now? > Can it not just call an ia64 specific function? Is it actually required to be a kernel module? (is it linked with the rest of the kernel?) If not, maybe it can be a .o file instead of a .ko, and loaded via the request_firmware() mechanism. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/