From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Guillaume Thouvenin
<guillaume.thouvenin-Z51IpKcfGtLk1uMJSBkQmQ@public.gmane.org>
Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [patch 2 of 2][rewritten] Emulate CMPS instruction
Date: Mon, 26 Nov 2007 17:13:02 +0200 [thread overview]
Message-ID: <474AE27E.7060101@qumranet.com> (raw)
In-Reply-To: <20071126134909.5fe49ad6-okVqAf2pJUEUMgAS9GT5UVaPQRlvutdw@public.gmane.org>
Guillaume Thouvenin wrote:
> This patch emulates the CMPS instruction. I made corrections requested
> by Avi (removed macro and added the memory access). I fixed an
> inversion between arguments VCPU_REGS_RSI and VCPU_REGS_RDI in function
> register_address(). I also added the test if DS segment is overridden
> with a segment override prefix (ES segment cannot be overriden).
>
Applied, thanks. It passes the emulator testsuite, but if I change m3
to m2 kvm spins without entering the guest (probably due to two reads
from mmio space in one instruction).
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2007-11-26 15:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 12:53 [patch 0 of 2] Emulate CMPS instruction Guillaume Thouvenin
[not found] ` <20071123135332.514d46e7-okVqAf2pJUEUMgAS9GT5UVaPQRlvutdw@public.gmane.org>
2007-11-23 12:56 ` [patch 1 of 2] Rename REP prefixes Guillaume Thouvenin
2007-11-23 12:57 ` [patch 2 of 2] Emulate CMPS instruction Guillaume Thouvenin
[not found] ` <20071123135743.288070e8-okVqAf2pJUEUMgAS9GT5UVaPQRlvutdw@public.gmane.org>
2007-11-23 17:54 ` Avi Kivity
[not found] ` <474713E6.10507-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-26 9:58 ` Guillaume Thouvenin
2007-11-26 12:49 ` [patch 2 of 2][rewritten] " Guillaume Thouvenin
[not found] ` <20071126134909.5fe49ad6-okVqAf2pJUEUMgAS9GT5UVaPQRlvutdw@public.gmane.org>
2007-11-26 15:13 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474AE27E.7060101@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=guillaume.thouvenin-Z51IpKcfGtLk1uMJSBkQmQ@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox