From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 2 of 2][rewritten] Emulate CMPS instruction Date: Mon, 26 Nov 2007 17:13:02 +0200 Message-ID: <474AE27E.7060101@qumranet.com> References: <20071123135332.514d46e7@frecb000711.bull.fr> <20071123135743.288070e8@frecb000711.bull.fr> <474713E6.10507@qumranet.com> <20071126134909.5fe49ad6@frecb000711.bull.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" To: Guillaume Thouvenin Return-path: In-Reply-To: <20071126134909.5fe49ad6-okVqAf2pJUEUMgAS9GT5UVaPQRlvutdw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Guillaume Thouvenin wrote: > This patch emulates the CMPS instruction. I made corrections requested > by Avi (removed macro and added the memory access). I fixed an > inversion between arguments VCPU_REGS_RSI and VCPU_REGS_RDI in function > register_address(). I also added the test if DS segment is overridden > with a segment override prefix (ES segment cannot be overriden). > Applied, thanks. It passes the emulator testsuite, but if I change m3 to m2 kvm spins without entering the guest (probably due to two reads from mmio space in one instruction). -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/