From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Neo Jia <neojia-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: emulation failed but !mmio_needed? rip 10000 fc 0f 01 15
Date: Tue, 27 Nov 2007 10:33:54 +0200 [thread overview]
Message-ID: <474BD672.1070801@qumranet.com> (raw)
In-Reply-To: <5d649bdb0711262337v28e7d3ecm246aa580cda0ca8b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Neo Jia wrote:
>>>
>>> Do we need to add a "default" in x86 emulator switch statement?
>>>
>>>
>>>
>> Take a look at the code. That path is already covered.
>>
>
> Avi,
>
> I just checkout the latest kvm.git. Please correct me if I am wrong.
>
> I don't see the explicit "default" in swtich (c->b) statement but I
> found a goto writeback.
>
If the insn decode flag word c->d (derived from opcode_table) is zero,
we return early. See the test just after the label 'done_prefixes'.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2007-11-27 8:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 23:23 emulation failed but !mmio_needed? rip 10000 fc 0f 01 15 Neo Jia
[not found] ` <5d649bdb0711231523r5221466cx6ee17979d27ddbc0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-11-24 4:21 ` Sheng Yang
[not found] ` <200711241221.00548.sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2007-11-24 7:48 ` Avi Kivity
2007-11-24 8:44 ` Neo Jia
2007-11-24 8:00 ` Avi Kivity
[not found] ` <4747DA35.6010001-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-24 8:30 ` Neo Jia
2007-11-24 9:45 ` Neo Jia
[not found] ` <5d649bdb0711240145g683f7762h35638e88586202a9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-11-25 9:44 ` Avi Kivity
[not found] ` <47494402.9020602-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-25 23:30 ` Neo Jia
[not found] ` <474A0590.4050701-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2007-11-26 10:16 ` Avi Kivity
[not found] ` <474A9CFE.50106-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-27 7:37 ` Neo Jia
[not found] ` <5d649bdb0711262337v28e7d3ecm246aa580cda0ca8b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-11-27 8:33 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474BD672.1070801@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=neojia-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox