From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: emulation failed but !mmio_needed? rip 10000 fc 0f 01 15 Date: Tue, 27 Nov 2007 10:33:54 +0200 Message-ID: <474BD672.1070801@qumranet.com> References: <5d649bdb0711231523r5221466cx6ee17979d27ddbc0@mail.gmail.com> <4747DA35.6010001@qumranet.com> <5d649bdb0711240145g683f7762h35638e88586202a9@mail.gmail.com> <47494402.9020602@qumranet.com> <474A0590.4050701@gmail.com> <474A9CFE.50106@qumranet.com> <5d649bdb0711262337v28e7d3ecm246aa580cda0ca8b@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Neo Jia Return-path: In-Reply-To: <5d649bdb0711262337v28e7d3ecm246aa580cda0ca8b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Neo Jia wrote: >>> >>> Do we need to add a "default" in x86 emulator switch statement? >>> >>> >>> >> Take a look at the code. That path is already covered. >> > > Avi, > > I just checkout the latest kvm.git. Please correct me if I am wrong. > > I don't see the explicit "default" in swtich (c->b) statement but I > found a goto writeback. > If the insn decode flag word c->d (derived from opcode_table) is zero, we return early. See the test just after the label 'done_prefixes'. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/