From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM external module: Fix 'make sync' Date: Fri, 30 Nov 2007 09:32:13 +0200 Message-ID: <474FBC7D.4000604@qumranet.com> References: <200711290313.33433.amit.shah@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Amit Shah Return-path: In-Reply-To: <200711290313.33433.amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Amit Shah wrote: > From a60dc9bddf8741743077db07f87dd1cec51bccb5 Mon Sep 17 00:00:00 2001 > From: Amit Shah > Date: Thu, 29 Nov 2007 03:11:15 +0530 > Subject: [PATCH] KVM external module: Fix 'make sync' > > bash syntax didn't work for me (3.2.25 on Kubuntu) > > Ah, bash isn't the default shell there. > ic/g' > $1 && rm $1.orig > > unifdef = mv $1 $1.orig && \ > - unifdef -DCONFIG_X86 $1.orig > $1; (( $$? <= 1 )) && rm $1.orig > + unifdef -DCONFIG_X86 $1.orig > $1; \ > + if [ $$? -lt 2 ]; then rm $1.orig; fi; > > The intent of the original code was to fail unifdef was not present, not to conditionalize removal (unifdef returns 1 on no change, so we need to test the error code explicitly). -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4