Re: [ kvm-Bugs-1840186 ] KVM "configure" script doesn't checks for "unifdef"

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Dan Kenigsberg wrote:
> On Wed, Nov 28, 2007 at 03:06:52AM -0800, SourceForge.net wrote:
>   
>> Bugs item #1840186, was opened at 2007-11-28 13:06
>> Message generated for change (Tracker Item Submitted) made by Item Submitter
>> You can respond by visiting: 
>> https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1840186&group_id=180599
>>
>> Please note that this message will contain a full copy of the comment thread,
>> including the initial issue submission, for this request,
>> not just the latest update.
>> Category: None
>> Group: None
>> Status: Open
>> Resolution: None
>> Priority: 5
>> Private: No
>> Submitted By: Technologov (technologov)
>> Assigned to: Nobody/Anonymous (nobody)
>> Summary: KVM "configure" script doesn't checks for "unifdef"
>>
>> Initial Comment:
>> Without "unifdef" package installed, KVM-54 refuses to compile from GIT on Fedora 7. Compilation works fine from .tar.gz.
>>
>> It is used by "make sync" command, but I believe that a user deserves to get a human-readable error.
>>
>> Either "make" or "configure" command must be fixed to handle such situations.
>>
>>     
>
> How about adding
>
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 22326b2..90930b2 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -31,6 +31,7 @@ sync:
>         rsync "$(LINUX)"/include/asm-x86/kvm_para.h include/asm
>         rsync "$(LINUX)"/include/asm-x86/kvm.h include/asm
>  
> +       type unifdef >/dev/null 2>&1 || echo sync requires unifdef && false
>         $(call unifdef, include/linux/kvm.h)
>         $(call unifdef, include/linux/kvm_para.h)
>         $(call unifdef, include/asm/kvm.h)
>
> ?
>   

kvm.git's make already handles this.

> P.S., why does a failed $(call) does not stop make as any other failed
> step? Is it a feature of 'make'?
>
>   

In general it does, but unifdef needs special handling since it returns
1 when all is fine (thanks unifdef developers).

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4