From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH]0/2 Patches to furthure split kvm_init Date: Fri, 30 Nov 2007 11:51:48 +0200 Message-ID: <474FDD34.9020807@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDCA394B2@pdsmsx415.ccr.corp.intel.com> <474E8D88.4090508@linux.vnet.ibm.com> <474FBF0D.7020601@qumranet.com> <42DFA526FC41B1429CE7279EF83C6BDCA397B9@pdsmsx415.ccr.corp.intel.com> <474FCB79.2010008@qumranet.com> <42DFA526FC41B1429CE7279EF83C6BDCA397CF@pdsmsx415.ccr.corp.intel.com> <474FD21E.8030900@qumranet.com> <42DFA526FC41B1429CE7279EF83C6BDCA397EA@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Christian Ehrhardt , carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDCA397EA-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Zhang, Xiantao wrote: >>> >> Ah, I see. It isn't just the alignment. How do you allocate >> kvm_vcpu, then? >> > > For evevy vm, we allocate a big chunk of memory for structure > allocation. For vcpu, it should be always 64k aligned through our > allocation mechanism. So, we don't care about its aligment issue :) > I see. Can you explain why you do that? Do you have a special allocator in your guest-resident vmm module? I don't think other archs need that, so a CONFIG_KVM_ARCH_CVPU_ALLOC approach seems better than copying all that code. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4