From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0 of 3] create kvm_x86 Date: Fri, 30 Nov 2007 22:31:39 +0200 Message-ID: <4750732B.7070502@qumranet.com> References: <4743F5AE.8090707@de.ibm.com> <4743F7DF.4000107@qumranet.com> <1196284556.9247.22.camel@basalt> <474FBB17.6080800@qumranet.com> <42DFA526FC41B1429CE7279EF83C6BDCA397C1@pdsmsx415.ccr.corp.intel.com> <474FD234.5060203@qumranet.com> <1196448210.7103.47.camel@basalt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, "Zhang, Xiantao" To: Hollis Blanchard Return-path: In-Reply-To: <1196448210.7103.47.camel@basalt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: > On Fri, 2007-11-30 at 11:04 +0200, Avi Kivity wrote: > >> Zhang, Xiantao wrote: >> >>>>> >>>>> >>>> The nicer one: >>>> >>>> struct kvm { >>>> struct kvm_arch arch; >>>> // common fields >>>> } >>>> >>>> >>> I prefer this one, seems it is more direct and readable. Same thinking >>> about kvm_vcpu structure:) >>> >>> >> I agree, kvm_vcpu should use the same method. >> > > And we will convert vcpu_vmx/vcpu_svm as well? > > These cannot use the same method, since we need to support both vmx and svm in the same binary. The arch specific members aren't the same size, nor do the symbols they use have the same visibility. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4