From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH]0/2 Patches to furthure split kvm_init Date: Fri, 30 Nov 2007 22:34:02 +0200 Message-ID: <475073BA.1090105@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDCA394B2@pdsmsx415.ccr.corp.intel.com> <474E8D88.4090508@linux.vnet.ibm.com> <474FBF0D.7020601@qumranet.com> <474FF970.9060404@de.ibm.com> <474FFA26.6020302@qumranet.com> <475006D5.9060504@de.ibm.com> <4750234D.6000504@qumranet.com> <1196446711.7103.34.camel@basalt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, Christian Ehrhardt , "Zhang, Xiantao" , kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Hollis Blanchard Return-path: In-Reply-To: <1196446711.7103.34.camel@basalt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: > On Fri, 2007-11-30 at 16:50 +0200, Avi Kivity wrote: > >> Carsten Otte wrote: >> >>> Avi Kivity wrote: >>> >>>> But you do need the vcpu cache, right? >>>> >>> I think about organizing our SIE control blocks in it, just like vmx >>> and svm do with their hardware structures backing a vcpu state. >>> They're 512 bytes in size, and need to start on a 512-byte boundary. >>> Sorry about my previous answer, I was confused by vcpu_cache / >>> vcpu_decache for x86. It's friday... >>> >> Ah, so you even need the alignment (which happen to be exactly the x86 >> fpu alignment). >> >> So we have two archs needing special allocation, and two archs using a >> common allocator. >> > > I think it's clear that this is an area that is likely to be very > architecture-specific, and I don't think that duplicating > kmem_cache_create() for each architecture is a big deal at all. > No, it isn't, but having a KVM_ARCH_HAS_VCPU_ALLOC isn't either. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4