Re: [PATCH 0 of 3] create kvm_x86

Avi Kivity
2007-11-30T20:31:39Z

Hollis Blanchard wrote:
> On Fri, 2007-11-30 at 11:04 +0200, Avi Kivity wrote:
>
>> Zhang, Xiantao wrote:
>>
>>>>>
>>>>>
>>>> The nicer one:
>>>>
>>>> struct kvm {
>>>> struct kvm_arch arch;
>>>> // common fields
>>>> }
>>>>
>>>>
>>> I prefer this one, seems it is more direct and readable. Same thinking
>>> about kvm_vcpu structure:)
>>>
>>>
>> I agree, kvm_vcpu should use the same method.
>>
>
> And we will convert vcpu_vmx/vcpu_svm as well?
>
>

These cannot use the same method, since we need to support both vmx and
svm in the same binary. The arch specific members aren't the same size,
nor do the symbols they use have the same visibility.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.