From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Eliminate the difference of ioapic andiosapic Date: Sun, 02 Dec 2007 22:35:22 +0200 Message-ID: <4753170A.7010905@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDCA3951B@pdsmsx415.ccr.corp.intel.com> <474FBFAB.7020407@qumranet.com> <42DFA526FC41B1429CE7279EF83C6BDCA397B3@pdsmsx415.ccr.corp.intel.com> <474FCA8C.2090809@qumranet.com> <42DFA526FC41B1429CE7279EF83C6BDCA3981F@pdsmsx415.ccr.corp.intel.com> <474FFA8F.7040403@qumranet.com> <42DFA526FC41B1429CE7279EF83C6BDCA398ED@pdsmsx415.ccr.corp.intel.com> <4752A859.2040909@qumranet.com> <42DFA526FC41B1429CE7279EF83C6BDCA3991B@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDCA3991B-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Zhang, Xiantao wrote: > Avi Kivity wrote: > >> Zhang, Xiantao wrote: >> >>> I didin't create the ioapic.h, since current irq.h has included >>> most the definitions of ioapic. Maybe we can create it later for >>> irq.h split. Now, I just put the definition in irq.h for delivery >>> mode. Since the delivery mode definitions doesn't depend on kernel >>> header files, so it will avoid possible failures with some special >>> .configs. >>> >>> >> Patch looks good, but please split into the dest_* -> IOAPIC_* change, >> and the lapic -> vcpu change, since the combined patch is a little >> big. >> > Done! Attached the patches. :) > Applied all; thanks. But please use git-send-email to send patches, they're easier to review that way. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4