How to handle kvm-abi-10 case for other archs.

How to handle kvm-abi-10 case for other archs.

[Zhang, Xiantao]

Hi, Avi
	I think new archs for kvm doesn't need to care about kvm-abi
case in their code, since current abi is bigger than 10. But in current
libkvm.c, we can see that many abi-specific code in it. How to handle it
?  Can we use __x86__ macro to make it sightless for other archs or
other good methods ?
Thanks
Xiantao

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

Re: How to handle kvm-abi-10 case for other archs.

[Avi Kivity]

Zhang, Xiantao wrote:
> Hi, Avi
> 	I think new archs for kvm doesn't need to care about kvm-abi
> case in their code, since current abi is bigger than 10. But in current
> libkvm.c, we can see that many abi-specific code in it. How to handle it
> ?  Can we use __x86__ macro to make it sightless for other archs or
> other good methods ?
>   

#ifdef is okay for this.  Actually we can probably remove abi 10 support 
since the F7 kernel now supports the modern ABI (I don't think anybody 
else uses abi 10, which is pre 2.6.22 when we announced ABI compatibility.

Jeremy, is removing abi 10 support fine with you?  I note that both the 
kernel supports the new ABI and F7 userspace doesn't require it, so 
we're fine on both counts.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

Re: How to handle kvm-abi-10 case for other archs.

[Jeremy Katz]

On Sat, 2007-12-01 at 12:10 +0200, Avi Kivity wrote:
> Zhang, Xiantao wrote:
> > 	I think new archs for kvm doesn't need to care about kvm-abi
> > case in their code, since current abi is bigger than 10. But in current
> > libkvm.c, we can see that many abi-specific code in it. How to handle it
> > ?  Can we use __x86__ macro to make it sightless for other archs or
> > other good methods ?
> >   
> 
> #ifdef is okay for this.  Actually we can probably remove abi 10 support 
> since the F7 kernel now supports the modern ABI (I don't think anybody 
> else uses abi 10, which is pre 2.6.22 when we announced ABI compatibility.
> 
> Jeremy, is removing abi 10 support fine with you?  I note that both the 
> kernel supports the new ABI and F7 userspace doesn't require it, so 
> we're fine on both counts.

Yeah, that sounds like it should be fine.  The updates have been out for
quite a while at this point

Jeremy


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

Re: How to handle kvm-abi-10 case for other archs.

[Zhang, Xiantao]

Jeremy Katz wrote:
> On Sat, 2007-12-01 at 12:10 +0200, Avi Kivity wrote:
>> Zhang, Xiantao wrote:
>>> 	I think new archs for kvm doesn't need to care about kvm-abi
>>> case in their code, since current abi is bigger than 10. But in
>>> current libkvm.c, we can see that many abi-specific code in it. How
>>> to handle it ?  Can we use __x86__ macro to make it sightless for
>>> other archs or other good methods ? 
>>> 
>> 
>> #ifdef is okay for this.  Actually we can probably remove abi 10
>> support since the F7 kernel now supports the modern ABI (I don't
>> think anybody else uses abi 10, which is pre 2.6.22 when we
>> announced ABI compatibility. 
>> 
>> Jeremy, is removing abi 10 support fine with you?  I note that both
>> the kernel supports the new ABI and F7 userspace doesn't require it,
>> so 
>> we're fine on both counts.
> 
> Yeah, that sounds like it should be fine.  The updates have been out
> for quite a while at this point

Glad to see that. I am working on enabling ia64. If it is removed, it
will be cleaner for us.

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

Re: How to handle kvm-abi-10 case for other archs.

[Avi Kivity]

Zhang, Xiantao wrote:
> Jeremy Katz wrote:
>   
>> On Sat, 2007-12-01 at 12:10 +0200, Avi Kivity wrote:
>>     
>>> Zhang, Xiantao wrote:
>>>       
>>>> 	I think new archs for kvm doesn't need to care about kvm-abi
>>>> case in their code, since current abi is bigger than 10. But in
>>>> current libkvm.c, we can see that many abi-specific code in it. How
>>>> to handle it ?  Can we use __x86__ macro to make it sightless for
>>>> other archs or other good methods ? 
>>>>         
> Glad to see that. I am working on enabling ia64. If it is removed, it
> will be cleaner for us.
>   

abi 10 support is now gone.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

Re: How to handle kvm-abi-10 case for other archs.

[Carlo Marcelo Arenas Belon]

On Sat, Dec 01, 2007 at 12:10:16PM +0200, Avi Kivity wrote:
> Zhang, Xiantao wrote:
> > Hi, Avi
> > 	I think new archs for kvm doesn't need to care about kvm-abi
> > case in their code, since current abi is bigger than 10. But in current
> > libkvm.c, we can see that many abi-specific code in it. How to handle it
> > ?  Can we use __x86__ macro to make it sightless for other archs or
> > other good methods ?
> >   
> 
> #ifdef is okay for this.  Actually we can probably remove abi 10 support 
> since the F7 kernel now supports the modern ABI (I don't think anybody 
> else uses abi 10, which is pre 2.6.22 when we announced ABI compatibility.

ubuntu feisty uses kernel 2.6.20 and is packaging kvm-16 :

  http://packages.ubuntu.com/feisty/misc/kvm

their last release (gutsy) uses 2.6.22 though.

Carlo

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

Re: How to handle kvm-abi-10 case for other archs.

[Zhang, Xiantao]

Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> Jeremy Katz wrote:
>> 
>>> On Sat, 2007-12-01 at 12:10 +0200, Avi Kivity wrote:
>>> 
>>>> Zhang, Xiantao wrote:
>>>> 
>>>>> 	I think new archs for kvm doesn't need to care about kvm-abi
>>>>> case in their code, since current abi is bigger than 10. But in
>>>>> current libkvm.c, we can see that many abi-specific code in it.
>>>>> How to handle it ?  Can we use __x86__ macro to make it sightless
>>>>> for other archs or other good methods ?
>>>>> 
>> Glad to see that. I am working on enabling ia64. If it is removed,
>> it will be cleaner for us. 
>> 
> 
> abi 10 support is now gone.

Thank you. That absoulutely simplify our work. :)
Xiantao

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

Re: How to handle kvm-abi-10 case for other archs.

[Avi Kivity]

Carlo Marcelo Arenas Belon wrote:

  

>> #ifdef is okay for this.  Actually we can probably remove abi 10 support 
>> since the F7 kernel now supports the modern ABI (I don't think anybody 
>> else uses abi 10, which is pre 2.6.22 when we announced ABI compatibility.
>>     
>
> ubuntu feisty uses kernel 2.6.20 and is packaging kvm-16 :
>
>   http://packages.ubuntu.com/feisty/misc/kvm
>   

kvm only started the ABI guarantee in 2.6.22.  Anyway this will only hit 
people trying to run kvm-56+ userspace atop 2.6.20, which is fairly 
ridiculous in terms of how far kvm went in that time.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4