From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM Date: Wed, 05 Dec 2007 12:25:50 +0200 Message-ID: <47567CAE.30301@qumranet.com> References: <20071202085006.C6D5A2508F6@il.qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Hollis Blanchard Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: >> >> diff --git a/drivers/kvm/Kconfig b/drivers/kvm/Kconfig index >> 6569206..4086080 100644 >> --- a/drivers/kvm/Kconfig >> +++ b/drivers/kvm/Kconfig >> @@ -3,7 +3,7 @@ >> # >> menuconfig VIRTUALIZATION >> bool "Virtualization" >> - depends on X86 >> + depends on ARCH_SUPPORTS_KVM || X86 >> default y > I think this approach is fine, but don't forget that lguest was snuck > into drivers/kvm/Kconfig. Actually I considered this. X86 in the depends statement above is short for "ARCH_SUPPORTS_LGUEST"; otherwise it is not needed. > It might be a good idea to move > CONFIG_VIRTUALIZATION into drivers/Kconfig at this point I prefer a top-level virt/ and arch/*/virt/. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4