From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Ehrhardt Subject: [PATCH] [0/1] simplify kvm-userspace to qemu-kvm callback structure Date: Fri, 07 Dec 2007 12:38:14 +0100 Message-ID: <475930A6.60301@linux.vnet.ibm.com> References: <4756BB14.1080708@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Jerone Young , Hollis Blanchard To: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" Return-path: In-Reply-To: <4756BB14.1080708-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Well no response might mean that there is nothing to be said against this simplification ;-) Because of that I completed the patch (main.c as well) and corrected some whitespace issues I had before. Christian Ehrhardt wrote: > Background: > In our ppc code for the demo we only needed a call to = > cpu_physical_memory_rw to handle all kind of mmio we needed. Looking at = > all the callback pointers for read/write mmio in kvm_callbacks I = > wondered if this can be simplified with cpu_physical_memory_rw for x86 = > too. So I tested it today and it works fine on with kvm-svm on my opteron. > The only code that did not just redirect to another function was a = > workaround for a Redhat 7.1 issue, so I merged it in the central call = > making it easier to find and maintain (was split before) anyway. > If everyone agrees with it I will create a new patch also affecting the = > other implementations of this interface e.g. user/main.c and a rebased = > version of this one. > But maybe there was a reason to do it that split way with all the = > callback pointers that was not obvious to me, so please comment. > [...] -- = Gr=FCsse / regards, = Christian Ehrhardt IBM Linux Technology Center, Open Virtualization +49 7031/16-3385 Ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Ehrhardt-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Johann Weihen = Gesch=E4ftsf=FChrung: Herbert Kircher = Sitz der Gesellschaft: B=F6blingen Registergericht: Amtsgericht Stuttgart, HRB 243294 ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php