Re: [PATCH] fix -kernel option

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Anthony Liguori wrote:
> Glauber de Oliveira Costa wrote:
>   
>> Currently, the -kernel option is not working.
>>
>> Reason is, because we're registering chunks for regions 0-0xa0000 and
>> 0x100000-ram_size, the phys_ram_addr + PA is broken.
>>   
>>     
>
> I think this patch is a reasonable work-around but the long term 
> solution is probably going to have to be making sure that nothing makes 
> the phys_ram_addr + PA assumption.  With > 4GB of memory, this 
> assumption is broken because of the BIOS/PCI holes anyway.  I guess we 
> could preserve this assumption though by burning some memory.
>
>   

We don't need to burn the memory, you can munmap() the unneeded part
after allocating it.

Just make sure you don't touch it afterwards. We used this method in
previous versions, then moved to the current approach which is more
aligned with how qemu does things.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php