[PATCH] Move CONFIG_X86 decleration to be x86 specific in configure script

[PATCH] Move CONFIG_X86 decleration to be x86 specific in configure script

[Jerone Young]

# HG changeset patch
# User Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
# Date 1196891226 21600
# Node ID a30e578bd6e2cf7599ce0c57066880658ddf2886
# Parent  b4cf8e05d20b3f4ca658bb4fdf3db3e4393a5d8a
Move CONFIG_X86 decleration to be x86 specific in configure script

In the configure script CONFIG_X86 is explicitly declared for
qemu. Now while today the support for other archs is not exactly
in kvm just yet (it's coming)..this shouldn't be specified for
everyone ;-)

Signed-off-by: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

diff --git a/configure b/configure
--- a/configure
+++ b/configure
@@ -99,6 +99,7 @@ fi
 #set parameters compiling
 if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
     target_exec="x86_64-softmmu"
+    qemu_cflags+=" -DCONFIG_X86"
 fi
 
 #configure user dir
@@ -109,7 +110,7 @@ fi
 #configure qemu
 (cd qemu; ./configure --target-list=$target_exec \
     --disable-kqemu \
-    --extra-cflags="-I $PWD/../libkvm $qemu_cflags -DCONFIG_X86" \
+    --extra-cflags="-I $PWD/../libkvm $qemu_cflags" \
     --extra-ldflags="-L $PWD/../libkvm $qemu_ldflags" \
     --enable-kvm --kernel-path="$libkvm_kerneldir" \
     ${enable_alsa:+"--enable-alsa"} \

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

Re: [PATCH] Move CONFIG_X86 decleration to be x86 specificin configure script

[Zhang, Xiantao]

[-- Attachment #1: Type: text/plain, Size: 1613 bytes --]

Jerone Young wrote:
> # HG changeset patch
> # User Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> # Date 1196891226 21600
> # Node ID a30e578bd6e2cf7599ce0c57066880658ddf2886
> # Parent  b4cf8e05d20b3f4ca658bb4fdf3db3e4393a5d8a
> Move CONFIG_X86 decleration to be x86 specific in configure script
> 
> In the configure script CONFIG_X86 is explicitly declared for
> qemu. Now while today the support for other archs is not exactly
> in kvm just yet (it's coming)..this shouldn't be specified for
> everyone ;-)
> 
> Signed-off-by: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> 
> diff --git a/configure b/configure
> --- a/configure
> +++ b/configure
> @@ -99,6 +99,7 @@ fi
>  #set parameters compiling
>  if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
>      target_exec="x86_64-softmmu"
> +    qemu_cflags+=" -DCONFIG_X86"

Hi, Young 
	Are you sure it works for you? Seems in script, it can't
recognize "+=".  Anyway, I also have a fix about it in my patch queue,
when  I do ia64 porting.  
Thanks
Xiantao


>
------------------------------------------------------------------------
-
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell.  From the desktop to the data center, Linux is going
> mainstream.  Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________
> kvm-devel mailing list
> kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/kvm-devel


[-- Attachment #2: 0003-kvm-qemu-Moving-CONFIG_X86-to-x86-arch-for-other.patch --]
[-- Type: application/octet-stream, Size: 1138 bytes --]

From 86c60dc416c8c8159bbe4c53bf6256a9d3cf82ce Mon Sep 17 00:00:00 2001
From: Zhang Xiantao <xiantao.zhang@intel.com>
Date: Wed, 5 Dec 2007 10:03:03 +0800
Subject: [PATCH] kvm : qemu : Moving CONFIG_X86 to x86 arch for other arch support.

Moving CONFIG_X86 to x86 arch for other arch support.
Signed-off-by: Zhang Xiantao <xiantao.zhang@intel.com>
---
 configure |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index c6b3ff3..dadda8e 100755
--- a/configure
+++ b/configure
@@ -99,6 +99,7 @@ fi
 #set parameters compiling
 if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
     target_exec="x86_64-softmmu"
+    qemu_cflags="$qemu_cflags -DCONFIG_X86"
 fi
 
 if [ "$arch" = "ia64" ]; then
@@ -113,7 +114,7 @@ fi
 #configure qemu
 (cd qemu; ./configure --target-list=$target_exec \
     --disable-kqemu \
-    --extra-cflags="-I $PWD/../libkvm $qemu_cflags -DCONFIG_X86" \
+    --extra-cflags="-I $PWD/../libkvm $qemu_cflags" \
     --extra-ldflags="-L $PWD/../libkvm $qemu_ldflags" \
     --enable-kvm --kernel-path="$libkvm_kerneldir" \
     ${enable_alsa:+"--enable-alsa"} \
-- 
1.5.2


[-- Attachment #3: Type: text/plain, Size: 309 bytes --]

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [PATCH] Move CONFIG_X86 decleration to be x86 specificin configure script

[Jerone Young]

 On Thu, 2007-12-06 at 11:06 +0800, Zhang, Xiantao wrote:
> Jerone Young wrote:
> > # HG changeset patch
> > # User Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> > # Date 1196891226 21600
> > # Node ID a30e578bd6e2cf7599ce0c57066880658ddf2886
> > # Parent  b4cf8e05d20b3f4ca658bb4fdf3db3e4393a5d8a
> > Move CONFIG_X86 decleration to be x86 specific in configure script
> > 
> > In the configure script CONFIG_X86 is explicitly declared for
> > qemu. Now while today the support for other archs is not exactly
> > in kvm just yet (it's coming)..this shouldn't be specified for
> > everyone ;-)
> > 
> > Signed-off-by: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> > 
> > diff --git a/configure b/configure
> > --- a/configure
> > +++ b/configure
> > @@ -99,6 +99,7 @@ fi
> >  #set parameters compiling
> >  if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
> >      target_exec="x86_64-softmmu"
> > +    qemu_cflags+=" -DCONFIG_X86"
> 
> Hi, Young 
> 	Are you sure it works for you? Seems in script, it can't
> recognize "+=".  Anyway, I also have a fix about it in my patch queue,
> when  I do ia64 porting.  

Really? Hmmm.. that is valid bash syntax.  Seems to work fine when I do
it on the command line. Also seems to work out in my script as well. If
this is the case then maybe it's a newer bash feature.

> Thanks
> Xiantao
> 
> 
> >
> ------------------------------------------------------------------------
> -
> > SF.Net email is sponsored by: The Future of Linux Business White Paper
> > from Novell.  From the desktop to the data center, Linux is going
> > mainstream.  Let it simplify your IT future.
> > http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> > _______________________________________________
> > kvm-devel mailing list
> > kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > https://lists.sourceforge.net/lists/listinfo/kvm-devel
> 
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell.  From the desktop to the data center, Linux is going
> mainstream.  Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

Re: [PATCH] Move CONFIG_X86 decleration to be x86 specificin configure script

[Avi Kivity]

Jerone Young wrote:
>> Hi, Young 
>> 	Are you sure it works for you? Seems in script, it can't
>> recognize "+=".  Anyway, I also have a fix about it in my patch queue,
>> when  I do ia64 porting.  
>>     
>
> Really? Hmmm.. that is valid bash syntax.  Seems to work fine when I do
> it on the command line. Also seems to work out in my script as well. If
> this is the case then maybe it's a newer bash feature.
>   

Not all systems use bash.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

Re: [PATCH] Move CONFIG_X86 decleration to be x86 specificin configure script

[Jerone Young]

 On Thu, 2007-12-06 at 21:30 +0200, Avi Kivity wrote:
> Jerone Young wrote:
> >> Hi, Young 
> >> 	Are you sure it works for you? Seems in script, it can't
> >> recognize "+=".  Anyway, I also have a fix about it in my patch queue,
> >> when  I do ia64 porting.  
> >>     
> >
> > Really? Hmmm.. that is valid bash syntax.  Seems to work fine when I do
> > it on the command line. Also seems to work out in my script as well. If
> > this is the case then maybe it's a newer bash feature.
> >   
> 
> Not all systems use bash.

True, but at the top of the configure script is "#!/bin/bash" :-)

perhaps an easier way is to just do 


qemu_cflags="$qemu_cflags --DCONFIG_X86"

This way there shouldn't be any issues.


Here is a patch:

Signed-off-by: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Move CONFIG_X86 decleration to be x86 specific in configure script

In the configure script CONFIG_X86 is explicitly declared for
qemu. 

Signed-off-by: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

diff --git a/configure b/configure
--- a/configure
+++ b/configure
@@ -99,6 +99,7 @@ fi
 #set parameters compiling
 if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
     target_exec="x86_64-softmmu"
+    qemu_cflags="$qemu_cflags -DCONFIG_X86"
 fi
 
 if [ "$arch" = "ia64" ]; then
@@ -113,7 +114,7 @@ fi
 #configure qemu
 (cd qemu; ./configure --target-list=$target_exec \
     --disable-kqemu \
-    --extra-cflags="-I $PWD/../libkvm $qemu_cflags -DCONFIG_X86" \
+    --extra-cflags="-I $PWD/../libkvm $qemu_cflags" \
     --extra-ldflags="-L $PWD/../libkvm $qemu_ldflags" \
     --enable-kvm --kernel-path="$libkvm_kerneldir" \
     ${enable_alsa:+"--enable-alsa"} \



-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

Re: [PATCH] Move CONFIG_X86 decleration tobe x86 specificin configure script

[Zhang, Xiantao]

Jerone Young wrote:
>  On Thu, 2007-12-06 at 21:30 +0200, Avi Kivity wrote:
>> Jerone Young wrote:
>>>> Hi, Young
>>>> 	Are you sure it works for you? Seems in script, it can't
>>>> recognize "+=".  Anyway, I also have a fix about it in my patch
>>>> queue, when  I do ia64 porting. 
>>>> 
>>> 
>>> Really? Hmmm.. that is valid bash syntax.  Seems to work fine when
>>> I do it on the command line. Also seems to work out in my script as
>>> well. If this is the case then maybe it's a newer bash feature.
>>> 
>> 
>> Not all systems use bash.
> 
> True, but at the top of the configure script is "#!/bin/bash" :-)
> 
> perhaps an easier way is to just do
> 
> 
> qemu_cflags="$qemu_cflags --DCONFIG_X86"
> 
> This way there shouldn't be any issues.
> 
> 
> Here is a patch:
> 
> Signed-off-by: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> 
> Move CONFIG_X86 decleration to be x86 specific in configure script
> 
> In the configure script CONFIG_X86 is explicitly declared for
> qemu.
> 
> Signed-off-by: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> 
> diff --git a/configure b/configure
> --- a/configure
> +++ b/configure
> @@ -99,6 +99,7 @@ fi
>  #set parameters compiling
>  if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
>      target_exec="x86_64-softmmu"
> +    qemu_cflags="$qemu_cflags -DCONFIG_X86"
>  fi
> 
>  if [ "$arch" = "ia64" ]; then
> @@ -113,7 +114,7 @@ fi
>  #configure qemu
>  (cd qemu; ./configure --target-list=$target_exec \
>      --disable-kqemu \
> -    --extra-cflags="-I $PWD/../libkvm $qemu_cflags -DCONFIG_X86" \
> +    --extra-cflags="-I $PWD/../libkvm $qemu_cflags" \
>      --extra-ldflags="-L $PWD/../libkvm $qemu_ldflags" \
>      --enable-kvm --kernel-path="$libkvm_kerneldir" \
>      ${enable_alsa:+"--enable-alsa"} \

Yes, That is also what I did in my patch. Been attached in privious mail
:)

Xiantao 

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

Re: [PATCH] Move CONFIG_X86 decleration tobe x86 specificin configure script

[Avi Kivity]

Zhang, Xiantao wrote:
> Yes, That is also what I did in my patch. Been attached in privious mail
> :)
>
>   

Ok, applied that one.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php