From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Ehrhardt Subject: Re: [PATCH] RFC: simplify kvm-userspace to qemu-kvm callback structure Date: Tue, 11 Dec 2007 14:01:34 +0100 Message-ID: <475E8A2E.7020406@linux.vnet.ibm.com> References: <4756BB14.1080708@linux.vnet.ibm.com> <47580C1B.4090708@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Jerone Young , Hollis Blanchard To: Avi Kivity Return-path: In-Reply-To: <47580C1B.4090708-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > Christian Ehrhardt wrote: >> Background: >> In our ppc code for the demo we only needed a call to = >> cpu_physical_memory_rw to handle all kind of mmio we needed. Looking = >> at all the callback pointers for read/write mmio in kvm_callbacks I = >> wondered if this can be simplified with cpu_physical_memory_rw for x86 = >> too. So I tested it today and it works fine on with kvm-svm on my = >> opteron. >> The only code that did not just redirect to another function was a = >> workaround for a Redhat 7.1 issue, so I merged it in the central call = >> making it easier to find and maintain (was split before) anyway. >> If everyone agrees with it I will create a new patch also affecting = >> the other implementations of this interface e.g. user/main.c and a = >> rebased version of this one. >> But maybe there was a reason to do it that split way with all the = >> callback pointers that was not obvious to me, so please comment. > = > It may be worthwhile to unify all the reads into a single read, but read = > and write are fundamentally different. The fact that qemu implements it = > in one function is a detail; libkvm aims to satisfy more than just qemu. > = That's fair - I thought too qemu-centric while the interface should be = generic. I changed the simplification patch to have separate read/write calls, but not one per len. That still reduce the different callbacks for mmio from eight to two pointers. To have it clean I put the updated patch in a separate mail. P.S. Sorry for overlooking your response and asking again. -- = Gr=FCsse / regards, = Christian Ehrhardt IBM Linux Technology Center, Open Virtualization +49 7031/16-3385 Ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Ehrhardt-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Johann Weihen = Gesch=E4ftsf=FChrung: Herbert Kircher = Sitz der Gesellschaft: B=F6blingen Registergericht: Amtsgericht Stuttgart, HRB 243294 ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php