From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC] Proposed new directory layout for kvm and virtualization Date: Tue, 11 Dec 2007 18:15:40 +0200 Message-ID: <475EB7AC.9040903@qumranet.com> References: <475E5CBB.9080608@qumranet.com> <20071211161032.GA25769@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel , kvm-devel To: Sam Ravnborg Return-path: In-Reply-To: <20071211161032.GA25769@uranus.ravnborg.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Sam Ravnborg wrote: > On Tue, Dec 11, 2007 at 11:47:39AM +0200, Avi Kivity wrote: > >> KVM is due to receive support for multiple architectures (ppc, ia64, and >> s390, in addition to the existing x86), hopefully in time for the 2.6.25 >> merge window. It is awkward to place the new arch support in >> drivers/kvm/, so I'd like to propose the following new layout: >> >> virt/ top-level directory for hypervisors >> virt/kvm/ kvm common code >> virt/lguest/ the other hypervisor >> arch/*/kvm/ arch dependent kvm code >> > > The arch/*/dir shall use same dir-name as used > in top-level directory. > Well, it isn't like that now (arch/x86/oprofile, etc.) > So use arch/*/virt/kvm/ if kvm really requires > a subdirectory of it own. Preferably not. > A handful of files named kvm* does not warrant their own > subdirectory IMO. > > We'll have 5-6 x86 specific files. Where do you suggest we place them? -- error compiling committee.c: too many arguments to function