From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC] Proposed new directory layout for kvm and virtualization Date: Tue, 11 Dec 2007 19:42:28 +0200 Message-ID: <475ECC04.8000609@qumranet.com> References: <475E5CBB.9080608@qumranet.com> <20071211161032.GA25769@uranus.ravnborg.org> <475EB7AC.9040903@qumranet.com> <20071211173717.GA26368@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , linux-kernel To: Sam Ravnborg Return-path: In-Reply-To: <20071211173717.GA26368-QabhHTsIXMSnlFQ6Q1D1Y0B+6BGkLq7r@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Sam Ravnborg wrote: > >>> So use arch/*/virt/kvm/ if kvm really requires >>> a subdirectory of it own. Preferably not. >>> A handful of files named kvm* does not warrant their own >>> subdirectory IMO. >>> >>> >>> >> We'll have 5-6 x86 specific files. >> >> Where do you suggest we place them? >> > /arch/x86/virt/ > > But, I want to place the arch independent files in virt/kvm/, so as to leave room for virt/lguest/. > Seems logical and fit the way we handle mm/ versus arch/*/mm, > kernel/ arch/*/kernel etc. > Exactly, so virt/kvm/ -> arch/x86/virt/kvm/. > Are there any dependencies between the arch and non-arch files > such as they are combined in a single module? > > Yes, they are combined into a single module. In the case of x86, some of arch/x86/... will be combined with virt/kvm/ to form kvm.ko, while others will generate kvm-intel.ko and kvm-amd.ko. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php