From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Heiko Carstens
<heiko.carstens-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC] Proposed new directory layout for kvm and virtualization
Date: Thu, 13 Dec 2007 10:33:45 +0200 [thread overview]
Message-ID: <4760EE69.2090006@qumranet.com> (raw)
In-Reply-To: <200712120014.43314.arnd-r2nGTMty4D4@public.gmane.org>
Arnd Bergmann wrote:
> On Tuesday 11 December 2007, Avi Kivity wrote:
>
>> Heiko Carstens wrote:
>>
>>> On Tue, Dec 11, 2007 at 11:47:39AM +0200, Avi Kivity wrote:
>>>
>>>
>>>> arch/*/kvm/ arch dependent kvm code
>>>>
>>>>
>>> Maybe arch/*/virt/ ? No need to add an own directory for each hypervisor.
>>>
>>>
>> There will be several kvm files in that directory for x86. If you have
>> just one file, I guess arch/*/virt/kvm.c is okay.
>>
>
> In that case, even arch/*/{mm,kernel}/kvm.c would work fine, as long as you
> only want to support one hypervisor, or a small set of small files, there
> is no need to have even have a virt directory.
>
> However, if you want to have symmetry across the architectures, I think
> arch/*/kvm/ works out best, along the lines of
> arch/*/{perfmon,crypto,xen,power}. Neither of these is particularly large,
> but arch/* is typically not that crowded either.
>
In the case of x86, we'll have 16 arch dependent files (i8259.[ch],
irq.[ch], lapic.c, mmu.c, paging_tmpl.[ch], svm.[ch], vmx.[ch],
x86.[ch], x86_emulate.[ch]) which warrant a kvm/ subdirectory IMO.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
next prev parent reply other threads:[~2007-12-13 8:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 9:47 [RFC] Proposed new directory layout for kvm and virtualization Avi Kivity
[not found] ` <475E5CBB.9080608-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-12-11 13:38 ` Christian Borntraeger
[not found] ` <200712111438.51142.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-12-11 13:46 ` Avi Kivity
2007-12-11 15:11 ` Heiko Carstens
[not found] ` <20071211151143.GA7751-Pmgahw53EmNLmI7Nx2oIsGnsbthNF6/HVpNB7YpNyf8@public.gmane.org>
2007-12-11 15:52 ` Avi Kivity
[not found] ` <475EB23E.1060002-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-12-11 23:14 ` Arnd Bergmann
[not found] ` <200712120014.43314.arnd-r2nGTMty4D4@public.gmane.org>
2007-12-13 8:33 ` Avi Kivity [this message]
2007-12-13 10:16 ` [kvm-devel] " Carsten Otte
2007-12-11 16:10 ` Sam Ravnborg
2007-12-11 16:15 ` Avi Kivity
[not found] ` <475EB7AC.9040903-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-12-11 17:37 ` Sam Ravnborg
[not found] ` <20071211173717.GA26368-QabhHTsIXMSnlFQ6Q1D1Y0B+6BGkLq7r@public.gmane.org>
2007-12-11 17:42 ` Avi Kivity
2007-12-11 18:26 ` [kvm-devel] " Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4760EE69.2090006@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=heiko.carstens-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox