From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC] Proposed new directory layout for kvm and virtualization Date: Thu, 13 Dec 2007 10:33:45 +0200 Message-ID: <4760EE69.2090006@qumranet.com> References: <475E5CBB.9080608@qumranet.com> <20071211151143.GA7751@osiris.boeblingen.de.ibm.com> <475EB23E.1060002@qumranet.com> <200712120014.43314.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Heiko Carstens , linux-kernel To: Arnd Bergmann Return-path: In-Reply-To: <200712120014.43314.arnd-r2nGTMty4D4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Arnd Bergmann wrote: > On Tuesday 11 December 2007, Avi Kivity wrote: > >> Heiko Carstens wrote: >> >>> On Tue, Dec 11, 2007 at 11:47:39AM +0200, Avi Kivity wrote: >>> >>> >>>> arch/*/kvm/ arch dependent kvm code >>>> >>>> >>> Maybe arch/*/virt/ ? No need to add an own directory for each hypervisor. >>> >>> >> There will be several kvm files in that directory for x86. If you have >> just one file, I guess arch/*/virt/kvm.c is okay. >> > > In that case, even arch/*/{mm,kernel}/kvm.c would work fine, as long as you > only want to support one hypervisor, or a small set of small files, there > is no need to have even have a virt directory. > > However, if you want to have symmetry across the architectures, I think > arch/*/kvm/ works out best, along the lines of > arch/*/{perfmon,crypto,xen,power}. Neither of these is particularly large, > but arch/* is typically not that crowded either. > In the case of x86, we'll have 16 arch dependent files (i8259.[ch], irq.[ch], lapic.c, mmu.c, paging_tmpl.[ch], svm.[ch], vmx.[ch], x86.[ch], x86_emulate.[ch]) which warrant a kvm/ subdirectory IMO. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace