Re: [2/6][PATCH] kvm: Moving memslot_id to x86.h

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Zhang, Xiantao wrote:
> Avi Kivity wrote:
>   
>> Zhang, Xiantao wrote:
>>     
>>> From: Zhang Xiantao <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>> Date: Tue, 11 Dec 2007 20:45:48 +0800
>>> Subject: [PATCH] kvm: Moving memslot_id to x86.h
>>>
>>> Since it is not called in kvm_main.c, and it also will block
>>> kvm structure split, so moved it out.
>>>
>>>       
>> memslot_id() is not x86 specific.  Why are you moving it?
>>     
>
> Maybe we can move it to kvm_main.c. If it is inline style in kvm.h, it
> will meet compile issue, since it needs to know kvm strucure. :)
>   

I see.  What we want is to #include "x86.h" at the beginning of kvm.h.

That means we need to switch to

    struct kvm {
         struct kvm_arch arch;
         ...
    };

(and similarly for struct kvm_vcpu) sooner rather than later.  Otherwise 
we will spiral into never-ending #include problems.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace