From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][5/22] kvm portability: Moving apic and apic_base to kvm_vcpu arch. Date: Fri, 14 Dec 2007 08:45:09 +0200 Message-ID: <47622675.2010607@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDCAD01FF@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDCAD01FF-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Zhang, Xiantao wrote: > From: Zhang Xiantao > Date: Fri, 14 Dec 2007 00:33:56 +0800 > Subject: [PATCH] kvm portability: Moving apic and apic_base to kvm_vcpu > arch. > > This patches moving apic and apic_base to kvm_vcpu_arch. > And use a macro apic(v) to simplifily get apic from vcpu. > > #define REG_POS(v) (((v) >> 5) << 4) > + > +#define apic(v) ((v)->arch.apic) > + > Using a macro called apic to reference a variable called apic is confusing. I'll undo it, no need to resubmit. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace