From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [PATCH][10/22] kvm: Portability : Moving pio_data, pio, mmio_fault_cr2 to arch. Date: Fri, 14 Dec 2007 12:17:59 +0100 Message-ID: <47626667.8090700@de.ibm.com> References: <42DFA526FC41B1429CE7279EF83C6BDCAD0206@pdsmsx415.ccr.corp.intel.com> <47625A9B.5090509@de.ibm.com> <47625B5A.5040209@qumranet.com> Reply-To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, "Zhang, Xiantao" To: Avi Kivity Return-path: In-Reply-To: <47625B5A.5040209-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > kvm_vcpu_fault() isn't for mapping guest pages, but for mapping the > kernel/userspace vcpu communication area. Moving that snippet to an > arch hook should be enough. Oh thanks for clearing my confusion. Indeed, hm... but we won't have a PIO_PAGE at all. On the other hand, we might need a data page for in-kernel devices too. Let's leave it like it is for now. ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace