Re: [PATCH] Make ioapic.c independent of x86 header files

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Zhang, Xiantao wrote:
> From: Zhang Xiantao <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Date: Sun, 16 Dec 2007 23:41:50 +0800
> Subject: [PATCH] kvm: Split irq.h into two parts, and make ioapic
> independent of
> X86 header files.
>
> This patch splits irq.h into two parts, and make ioapic independent of
> X86 header files.
>   


>  2 files changed, 100 insertions(+), 87 deletions(-)
>  create mode 100644 arch/x86/kvm/ioapic.h
>
> diff --git a/arch/x86/kvm/ioapic.h b/arch/x86/kvm/ioapic.h
> new file mode 100644
> index 0000000..5a01013
> --- /dev/null
> +++ b/arch/x86/kvm/ioapic.h
> @@ -0,0 +1,98 @@
> +#ifndef __KVM_IO_APIC_H
> +#define __KVM_IO_APIC_H
>   

blank line here

> +#include <linux/kvm_host.h>
> +#include "iodev.h"
> +
> +}
> +
> +static inline int irqchip_in_kernel(struct kvm *kvm)
> +{
> +	return ioapic_irqchip(kvm) != NULL;
> +}
>   

This doesn't belong here.  Also, the definition is changed -- you should 
have noted that.

I think for ia64 you can set irqchip_in_kernel() to return true 
unconditionally.

> +void kvm_vcpu_kick(struct kvm_vcpu *vcpu);
>   

Doesn't belong here, maybe kvm_host.h.

> +struct kvm_vcpu *kvm_get_lowest_prio_vcpu(struct kvm *kvm, u8 vector,
> +				       unsigned long bitmap);
> +void kvm_ioapic_update_eoi(struct kvm *kvm, int vector);
> +int kvm_ioapic_init(struct kvm *kvm);
> +void kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq, int level);
> +void kvm_ioapic_reset(struct kvm_ioapic *ioapic);
> +
> +int kvm_apic_match_physical_addr(struct kvm_lapic *apic, u16 dest);
> +int kvm_apic_match_logical_addr(struct kvm_lapic *apic, u8 mda);
> +int kvm_apic_set_irq(struct kvm_vcpu *vcpu, u8 vec, u8 trig);
> +int kvm_create_lapic(struct kvm_vcpu *vcpu);
> +void kvm_free_lapic(struct kvm_vcpu *vcpu);
>   

The non-ioapic functions shouldn't be here.


-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace