From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Ehrhardt Subject: Re: [PATCH][UPDATE] kvm-userspace: sync icache for morearchitectures Date: Tue, 18 Dec 2007 13:58:48 +0100 Message-ID: <4767C408.6060008@linux.vnet.ibm.com> References: <11975745782686-git-send-email-ehrhardt@linux.vnet.ibm.com> <42DFA526FC41B1429CE7279EF83C6BDCAD01E3@pdsmsx415.ccr.corp.intel.com> <476247EB.9040003@linux.vnet.ibm.com> <1197943018.5026.0.camel@diesel> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, "Zhang, Xiantao" , Avi Kivity , qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org To: Hollis Blanchard Return-path: In-Reply-To: <1197943018.5026.0.camel@diesel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: > On Fri, 2007-12-14 at 10:07 +0100, Christian Ehrhardt wrote: >> Hollis Blanchard wrote: >>> A comment to explain why the icache needs flushing only in the KVM >> case >>> would be useful. Other than that I'm fine with it. >>> >>> Signed-off-by: Hollis Blanchard >> AFAIK Plain qemu does not directly execute guest code on the >> processor, >> so the icache is not an issue for it. >> Qemu itself has the flush_icache_range function only as helper for the >> dynamic code generation. >> But we may now write executable guest code with our intercepted mmio >> handling that is directly executed when switching back to the guest >> context, therefore we need that invalidation in the kvm case. >> >> For the case that I'm overlooking something in plain qemu, so that it >> might need it too I add qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org for comments from there, >> but currently I think to have it in #ifdef USE_KVM is the right way. >> >> >> P.S. Hollis did you mean you would like to see a comment in the code >> where that call takes place? > = > Yes! Hopefully much shorter than this email... :-P > = comment added, rebased and resent together with a updated mmio callback simplification patch - I hope I didn't overlook a response to the mmio callback thread again this time ;-) -- = Gr=FCsse / regards, = Christian Ehrhardt IBM Linux Technology Center, Open Virtualization +49 7031/16-3385 Ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Ehrhardt-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Johann Weihen = Gesch=E4ftsf=FChrung: Herbert Kircher = Sitz der Gesellschaft: B=F6blingen Registergericht: Amtsgericht Stuttgart, HRB 243294 ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace