From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Carlo Marcelo Arenas Belon
<carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] [RESEND] libkvm: NULL pointer dereference in kvm_destroy_phys_mem as used in kvm-56
Date: Tue, 18 Dec 2007 18:20:03 +0200 [thread overview]
Message-ID: <4767F333.5010907@qumranet.com> (raw)
In-Reply-To: <20071218083753.GA15987@tapir>
Carlo Marcelo Arenas Belon wrote:
> The following patch eliminates the uninitialized mem pointer, using
> instead the corresponding entry from the slots array to fix :
>
> libkvm.c:580: warning: 'mem' is used uninitialized in this function
>
> Also changes the formatting type for phys_addr to long to prevent :
>
> libkvm.c:581: warning: format '%llx' expects type 'long long unsigned int'
> , but argument 5 has type 'long unsigned int'
>
>
Applied, thanks. But please avoid unrelated changes in the same patch
in the future.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
next prev parent reply other threads:[~2007-12-18 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 6:58 [PATCH] libkvm: null pointer dereference in kvm_destroy_phys_mem Carlo Marcelo Arenas Belon
2007-12-18 8:37 ` [PATCH] [RESEND] libkvm: NULL pointer dereference in kvm_destroy_phys_mem as used in kvm-56 Carlo Marcelo Arenas Belon
2007-12-18 16:20 ` Avi Kivity [this message]
[not found] ` <4767F333.5010907-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-12-19 15:30 ` Carlo Marcelo Arenas Belon
2007-12-19 15:29 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4767F333.5010907@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox