From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] [RESEND] libkvm: NULL pointer dereference in kvm_destroy_phys_mem as used in kvm-56 Date: Tue, 18 Dec 2007 18:20:03 +0200 Message-ID: <4767F333.5010907@qumranet.com> References: <20071214065827.GA12031@tapir> <20071218083753.GA15987@tapir> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Carlo Marcelo Arenas Belon Return-path: In-Reply-To: <20071218083753.GA15987@tapir> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carlo Marcelo Arenas Belon wrote: > The following patch eliminates the uninitialized mem pointer, using > instead the corresponding entry from the slots array to fix : > > libkvm.c:580: warning: 'mem' is used uninitialized in this function > > Also changes the formatting type for phys_addr to long to prevent : > > libkvm.c:581: warning: format '%llx' expects type 'long long unsigned int' > , but argument 5 has type 'long unsigned int' > > Applied, thanks. But please avoid unrelated changes in the same patch in the future. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace