public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Carlo Marcelo Arenas Belon
	<carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [RFC] external module: compatibility with older kernels (SMP and non SMP)
Date: Tue, 18 Dec 2007 18:32:58 +0200	[thread overview]
Message-ID: <4767F63A.9020701@qumranet.com> (raw)
In-Reply-To: <20071218130023.GA19231@tapir>

Carlo Marcelo Arenas Belon wrote:
> The following patch (which is composed of 3 different patches from a series)
> has been validated to solve compilation issues observed with kvm-56 in x86
> with kernels older than 2.6.21 and are posted here for testing and debate.
>
> The main points accomplished (in the same sequence that the snippets) are :
>
> * kernel <= 2.6.16 doesn't define memcpy or strcmp before used by kvm_para.h
> * complement f2601fd2874b94d14dfcb21a3e1b84d7f3262b17 reverting the inclusion
>   of io_apic.h which to simplify handling of older kernels
> * kernel < 2.6.21 define MAX_IO_APICS to fix non SMP compilations
>
>   

Looks good, but please split into separate patches.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

  reply	other threads:[~2007-12-18 16:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-18 13:00 [RFC] external module: compatibility with older kernels (SMP and non SMP) Carlo Marcelo Arenas Belon
2007-12-18 16:32 ` Avi Kivity [this message]
     [not found]   ` <4767F63A.9020701-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-12-19 12:18     ` [PATCH] external module: remove dependency on <asm/io_apic.h> Carlo Marcelo Arenas Belon
2007-12-19 15:44       ` Avi Kivity
2007-12-19 12:20     ` [PATCH] external module: define MAX_IO_APICS if missing Carlo Marcelo Arenas Belon
2007-12-19 12:26     ` [PATCH] external module: <linux/string.h> needed for kernel<=2.6.16 to define strcmp and memcpy Carlo Marcelo Arenas Belon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4767F63A.9020701@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox