From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 3/5] KVM: add kvm_follow_page() Date: Sun, 23 Dec 2007 10:41:07 +0200 Message-ID: <476E1F23.3020609@qumranet.com> References: <20071221001821.029994250@redhat.com> <20071221002024.345682789@redhat.com> <476D68A3.3000200@qumranet.com> <20071223052513.GA19072@dmt> <476E083B.5040600@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Andrew Morton To: Marcelo Tosatti Return-path: In-Reply-To: <476E083B.5040600-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > > Exactly. But it is better to be explicit about it and pass the page > directly like you did before. I hate to make you go back-and-fourth, > but I did not understand the issue completely before. > btw, the call to gfn_to_page() can happen in page_fault() instead of walk_addr(); that will reduce the amount of error handling, and will simplify the callers to walk_addr() that don't need the page. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/