From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 3/5] KVM: add kvm_follow_page() Date: Mon, 24 Dec 2007 16:36:32 +0200 Message-ID: <476FC3F0.90700@qumranet.com> References: <20071223052513.GA19072@dmt> <476E083B.5040600@qumranet.com> <476E1F23.3020609@qumranet.com> <476E236A.9000800@qumranet.com> <20071223012618.e8cf8320.akpm@linux-foundation.org> <476E39F2.4030202@qumranet.com> <20071223025245.d839c86d.akpm@linux-foundation.org> <476E4005.90003@qumranet.com> <20071223201525.GA14259@dmt> <476F5801.2030002@qumranet.com> <20071224142624.GA20275@dmt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Andrew Morton , Matt Mackall To: Marcelo Tosatti Return-path: In-Reply-To: <20071224142624.GA20275@dmt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Marcelo Tosatti wrote: > >> I believe that a new get_users_pages_inatomic() is more suitable; >> Andrew, I'll write it if you agree. Alternatively, walk_page_range() >> should take the lock itself, otherwise it is only usable if you don't >> care about correctness? >> > > Why not just export follow_page() ? That is exactly what KVM needs. > > Well, follow_page() needs the vma, and doesn't support large pages. It's too low-level to be a public API. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/