From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: external module sched_in event Date: Tue, 25 Dec 2007 11:00:27 +0200 Message-ID: <4770C6AB.2060303@qumranet.com> References: <20071220162353.GA3802@v2.random> <476D61E8.5000102@qumranet.com> <20071223164932.GA8483@v2.random> <476E9CE4.2060705@qumranet.com> <20071224162639.GH8483@v2.random> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Andrea Arcangeli Return-path: In-Reply-To: <20071224162639.GH8483-lysg2Xt5kKMAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Andrea Arcangeli wrote: > On Sun, Dec 23, 2007 at 07:37:40PM +0200, Avi Kivity wrote: > >> The sched_in notifier needs to enable interrupts (but it must disable >> preemption to avoid recursion). >> > > Ok this update fixes the smp_call_function deadlock. > > I was able to boot a 4-way guest on a 2-way i386 host, so looks like this works. Thanks, it will reduce the maintenance burden needed for the external module. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/