From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: README: How to run kvm guests on IA64 Date: Thu, 27 Dec 2007 12:36:26 +0200 Message-ID: <4773802A.4070505@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDCB13818@pdsmsx415.ccr.corp.intel.com> <200712271204.05539.amit.shah@qumranet.com> <42DFA526FC41B1429CE7279EF83C6BDCB572ED@pdsmsx415.ccr.corp.intel.com> <200712271419.42845.amit.shah@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, "Zhang, Xiantao" To: Amit Shah Return-path: In-Reply-To: <200712271419.42845.amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Amit Shah wrote: > On Thursday 27 December 2007 13:20:06 Zhang, Xiantao wrote: > >>>> It shouldn't have any confilicts, since they belong to different >>>> archs. Currently, you know source code is placed at >>>> arch/{$arch}/kvm, and Makefile and Kconfig aslo there. >>>> So, it doesn't impact any issues, since ia64 and x86_64 are totally >>>> different archs. For example, you can define HAS_IO_PORT macro for >>>> ia64 and x86, but they don't invoke any conficlts.:) >>>> >>> What about files that get shared? >>> >> I think common files shouldn't use KVM_CONFIG_INTEL. >> > > Even then I'm not sure we should use a common #define within the sources that > will apply to two different architectures in different ways under different > build environments. Avi, what do you think? > I agree in principle, but I don't see a big hurry to change things. Let's get it merged first. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/