README: How to run kvm guests on IA64

README: How to run kvm guests on IA64

[Zhang, Xiantao]

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

		KVM/IA64 HOWTO
This is the notes about how to enalbe kvm on Itanium series of
processors
suppoting VT. Since fully userspace built is not supported yet, so we
have to
build qemu, and kernel module separately. 
The step-by-step is as following:

Kernel module built: 

Download kvm source tree. 
1. Apply kernel.patch to your kernel source. 
2. Make menuconfig to enable virtulization support in kernel.
3. Build and install kernel. Reboot with new kernel. 
4. Insert kvm.ko kvm-intel.ko to kernel. 

Userspace built:

1. Download kvm-userspace source.
2. ./configure
3. cd kernel
4. make sync LINUX= "Your kvm kernel source directory."
5. make qemu
6. make install 

Run guests with the command :
/usr/local/bin/qemu-system-ia64 -hda your.img -m 512

If you have any question, please feel free to contact me! 

Thanks

Zhang Xiantao <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>	2007.12.19

[-- Attachment #2: README --]
[-- Type: application/octet-stream, Size: 872 bytes --]

		KVM/IA64 howto
This is the notes about how to enalbe kvm on Itanium series of processors
suppoting VT. Since fully userspace built is not supported yet, so we have to
build qemu, and kernel module separately. 
The step-by-step is as following:

Kernel module built: 

Download kvm source tree. 
1. Apply kernel.patch to your kernel source. 
2. Make menuconfig to enable virtulization support in kernel.
3. Build and install kernel. Reboot with new kernel. 
4. Insert kvm.ko kvm-intel.ko to kernel. 

Userspace built:

1. Download kvm-userspace source.
2. ./configure
3. cd kernel
4. make sync LINUX= "Your kvm kernel source directory."
5. make qemu
6. make install 

Run guests with the command :
/usr/local/bin/qemu-system-ia64 -hda your.img -m 512

If you have any question, please feel free to contact me! 

Thanks

Zhang Xiantao <xiantao.zhang@intel.com>	2007.12.19

[-- Attachment #3: Type: text/plain, Size: 308 bytes --]

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: README: How to run kvm guests on IA64

[Carlo Marcelo Arenas Belon]

On Wed, Dec 19, 2007 at 08:22:01PM +0800, Zhang, Xiantao wrote:
> 		KVM/IA64 HOWTO
> This is the notes about how to enalbe kvm on Itanium series of
> processors suppoting VT.

Probably some tidbits of this should go into the kvm wiki in :

  http://kvm.qumranet.com/kvmwiki/Host_Support_Status
  http://kvm.qumranet.com/kvmwiki/Status

> If you have any question, please feel free to contact me! 

to complete the host emulation and run a guest shouldn't an EFI 
BIOS be needed?

Carlo

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

Re: README: How to run kvm guests on IA64

[Zhang, Xiantao]

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

Carlo Marcelo Arenas Belon wrote:
> On Wed, Dec 19, 2007 at 08:22:01PM +0800, Zhang, Xiantao wrote:
>> 		KVM/IA64 HOWTO
>> This is the notes about how to enalbe kvm on Itanium series of
>> processors suppoting VT.
> 
> Probably some tidbits of this should go into the kvm wiki in :
> 
>   http://kvm.qumranet.com/kvmwiki/Host_Support_Status
>   http://kvm.qumranet.com/kvmwiki/Status

Sure :)

>> If you have any question, please feel free to contact me!
> 
> to complete the host emulation and run a guest shouldn't an EFI
> BIOS be needed?
Sorry for missing it. 
Yes, it also need a EFI guest bios. Now, we have two bios (guest
firmware). One is from Intel, and only released as binary, and the other
one is open sourced, but seems there is minor issues on kvm with it.   I
attached an doc from Mu Qin about how to build it step by step.  If you
need the binary, I can upload it. :)

Xiantao

[-- Attachment #2: Open GFW Building HowTo.pdf --]
[-- Type: application/octet-stream, Size: 93449 bytes --]

[-- Attachment #3: Type: text/plain, Size: 308 bytes --]

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: README: How to run kvm guests on IA64

[Akio Takebe]

Hi,

>Run guests with the command :
>/usr/local/bin/qemu-system-ia64 -hda your.img -m 512
>
>If you have any question, please feel free to contact me! 
Can I use the guest image of Xen?
Or do I need to clean-install Linux or Windows on KVM guest?

Best Regards,

Akio Takebe


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: README: How to run kvm guests on IA64

[Zhang, Xiantao]

Akio Takebe wrote:
> Hi,
> 
>> Run guests with the command :
>> /usr/local/bin/qemu-system-ia64 -hda your.img -m 512
>> 
>> If you have any question, please feel free to contact me!
> Can I use the guest image of Xen?
> Or do I need to clean-install Linux or Windows on KVM guest?

Sure, you can use xen's hvm image directly :)
Xiantao 

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: README: How to run kvm guests on IA64

[Zhang, Xiantao]

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

Akio Takebe wrote:
> Hi,
> 
>> Run guests with the command :
>> /usr/local/bin/qemu-system-ia64 -hda your.img -m 512
>> 
>> If you have any question, please feel free to contact me!
> Can I use the guest image of Xen?
> Or do I need to clean-install Linux or Windows on KVM guest?
Hi, Akio
Thank you for your try!
In addition, If you want to boot windows up on Open GFW, you also need
to pick up the patch I sent to xen-ia64 mailing list, and built it with
latest efi-vfirmware.hg source. 
I attached it in this mail.
Xiantao

[-- Attachment #2: Type: message/rfc822, Size: 6149 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 851 bytes --]

Hi Tristan, 
This patch fixes possible failures on windows boot in some environment. 
Since current piix3 and piix4 in qemu only uses irq 10 and irq 11 for
pci irqs, so
here don't need to assign irq 5 and irq 6 for this purpose. IRQ 6 may
conflict
with the irq of legacy floppy disk controllers. 

diff -r f263d2bca359 edk2-sparse/EdkXenPkg/Dxe/XenAcpi/build.c
--- a/edk2-sparse/EdkXenPkg/Dxe/XenAcpi/build.c	Wed Dec 12 02:02:32 2007
+0100
+++ b/edk2-sparse/EdkXenPkg/Dxe/XenAcpi/build.c	Tue Dec 25 14:59:34 2007
+0800
@@ -33,7 +33,7 @@
 #define LSAPIC_ID(n) n
 extern int get_vcpu_nr (void);
 #define get_apic_mode() 1
-#define PCI_ISA_IRQ_MASK    0x0c60U /* ISA IRQs 5,6,10,11 are PCI
connected */
+#define PCI_ISA_IRQ_MASK    0x0c00U /* ISA IRQs 10,11 are PCI connected
*/
 #endif
 
 #define align16(sz) (((sz) + 15) & ~15)

[-- Attachment #2.1.2: diff --]
[-- Type: application/octet-stream, Size: 753 bytes --]

Since current piix3 and piix4 in qemu only uses irq 10 and irq 11 for pci irqs, so
here don't need to set irq 5 and irq 6 for this purpose. IRQ 6 may conflict
with the irq of legacy floppy disk controllers.

diff -r f263d2bca359 edk2-sparse/EdkXenPkg/Dxe/XenAcpi/build.c
--- a/edk2-sparse/EdkXenPkg/Dxe/XenAcpi/build.c	Wed Dec 12 02:02:32 2007 +0100
+++ b/edk2-sparse/EdkXenPkg/Dxe/XenAcpi/build.c	Tue Dec 25 14:59:34 2007 +0800
@@ -33,7 +33,7 @@
 #define LSAPIC_ID(n) n
 extern int get_vcpu_nr (void);
 #define get_apic_mode() 1
-#define PCI_ISA_IRQ_MASK    0x0c60U /* ISA IRQs 5,6,10,11 are PCI connected */
+#define PCI_ISA_IRQ_MASK    0x0c00U /* ISA IRQs 10,11 are PCI connected */
 #endif
 
 #define align16(sz) (((sz) + 15) & ~15)

[-- Attachment #2.1.3: ATT2944940.txt --]
[-- Type: text/plain, Size: 155 bytes --]

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: README: How to run kvm guests on IA64

[Akio Takebe]

Hi, Xiantao

>Akio Takebe wrote:
>> Hi,
>> 
>>> Run guests with the command :
>>> /usr/local/bin/qemu-system-ia64 -hda your.img -m 512
>>> 
>>> If you have any question, please feel free to contact me!
>> Can I use the guest image of Xen?
>> Or do I need to clean-install Linux or Windows on KVM guest?
>Hi, Akio
>Thank you for your try!
>In addition, If you want to boot windows up on Open GFW, you also need
>to pick up the patch I sent to xen-ia64 mailing list, and built it with
>latest efi-vfirmware.hg source. 
>I attached it in this mail.
Thank you. Your README doesn't explain about GFW.
How do we specify GFW as qemu's option?
Or must we put GFW in somewhere?

Best Regards,

Akio Takebe


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: README: How to run kvm guests on IA64

[Zhang, Xiantao]

Akio Takebe wrote:
> Hi, Xiantao
> 
>> Akio Takebe wrote:
>>> Hi,
>>> 
>>>> Run guests with the command :
>>>> /usr/local/bin/qemu-system-ia64 -hda your.img -m 512
>>>> 
>>>> If you have any question, please feel free to contact me!
>>> Can I use the guest image of Xen?
>>> Or do I need to clean-install Linux or Windows on KVM guest?
>> Hi, Akio
>> Thank you for your try!
>> In addition, If you want to boot windows up on Open GFW, you also
>> need to pick up the patch I sent to xen-ia64 mailing list, and built
>> it with latest efi-vfirmware.hg source.
>> I attached it in this mail.
> Thank you. Your README doesn't explain about GFW.
> How do we specify GFW as qemu's option?
> Or must we put GFW in somewhere?

I will update to kvm wiki.  We should put GFW named as Flash.fd to
/usr/local/share/qemu/ :) 

Xiantao


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: README: How to run kvm guests on IA64

[Akio Takebe]

Hi, Xiantao

>Akio Takebe wrote:
>> Hi, Xiantao
>> 
>>> Akio Takebe wrote:
>>>> Hi,
>>>> 
>>>>> Run guests with the command :
>>>>> /usr/local/bin/qemu-system-ia64 -hda your.img -m 512
>>>>> 
>>>>> If you have any question, please feel free to contact me!
>>>> Can I use the guest image of Xen?
>>>> Or do I need to clean-install Linux or Windows on KVM guest?
>>> Hi, Akio
>>> Thank you for your try!
>>> In addition, If you want to boot windows up on Open GFW, you also
>>> need to pick up the patch I sent to xen-ia64 mailing list, and built
>>> it with latest efi-vfirmware.hg source.
>>> I attached it in this mail.
>> Thank you. Your README doesn't explain about GFW.
>> How do we specify GFW as qemu's option?
>> Or must we put GFW in somewhere?
>
>I will update to kvm wiki.  We should put GFW named as Flash.fd to
>/usr/local/share/qemu/ :) 
Thank you for your advice.
Although I may still have some wrong steps,
I can boot up RHEL5.1 guest on kvm-ia64. :)
It works fine now!

Best Regards,

Akio Takebe


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: README: How to run kvm guests on IA64

[Zhang, Xiantao]

Akio Takebe wrote:
> Hi, Xiantao
> 
>> Akio Takebe wrote:
>>> Hi, Xiantao
>>> 
>>>> Akio Takebe wrote:
>>>>> Hi,
>>>>> 
>>>>>> Run guests with the command :
>>>>>> /usr/local/bin/qemu-system-ia64 -hda your.img -m 512
>>>>>> 
>>>>>> If you have any question, please feel free to contact me!
>>>>> Can I use the guest image of Xen?
>>>>> Or do I need to clean-install Linux or Windows on KVM guest?
>>>> Hi, Akio
>>>> Thank you for your try!
>>>> In addition, If you want to boot windows up on Open GFW, you also
>>>> need to pick up the patch I sent to xen-ia64 mailing list, and
>>>> built it with latest efi-vfirmware.hg source.
>>>> I attached it in this mail.
>>> Thank you. Your README doesn't explain about GFW.
>>> How do we specify GFW as qemu's option?
>>> Or must we put GFW in somewhere?
>> 
>> I will update to kvm wiki.  We should put GFW named as Flash.fd to
>> /usr/local/share/qemu/ :)
> Thank you for your advice.
> Although I may still have some wrong steps,
> I can boot up RHEL5.1 guest on kvm-ia64. :)
> It works fine now!
Hi, Akio
	Good news!  Glad to see you are successful to boot it up. Maybe
you can also try windows 2003, it should works fine as well :)
Xiantao

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: README: How to run kvm guests on IA64

[Amit Shah]

On Wednesday 19 December 2007 17:52:01 Zhang, Xiantao wrote:
> 		KVM/IA64 HOWTO
> This is the notes about how to enalbe kvm on Itanium series of
> processors
> suppoting VT. Since fully userspace built is not supported yet, so we
> have to
> build qemu, and kernel module separately.
> The step-by-step is as following:
>
> Kernel module built:
>
> Download kvm source tree.
> 1. Apply kernel.patch to your kernel source.
> 2. Make menuconfig to enable virtulization support in kernel.
> 3. Build and install kernel. Reboot with new kernel.
> 4. Insert kvm.ko kvm-intel.ko to kernel.

kvm-intel is the name of the module fox x86-intel. Do we have a collision 
here? Or is this supposed to load the x86 one on x86 and ia64 one on  ia64?

OK, I just saw your patches for Kconfig and Makefiles and we use 
CONFIG_KVM_INTEL for ia64 as well as x86. We should separate out these two 
before we run into troubles.

> Userspace built:
>
> 1. Download kvm-userspace source.
> 2. ./configure

./configure --with-patched-kernel in case you want to use the modules from the 
kernel that was built as mentioned above.

> 3. cd kernel
> 4. make sync LINUX= "Your kvm kernel source directory."

This step isn't needed if you build and install the kernel and plan to use the 
same modules. This is only needed if you want to upgrade kvm without 
upgrading the kernel or rebooting.

> 5. make qemu
> 6. make install
>
> Run guests with the command :
> /usr/local/bin/qemu-system-ia64 -hda your.img -m 512
>
> If you have any question, please feel free to contact me!
>
> Thanks
>
> Zhang Xiantao <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>	2007.12.19



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: README: How to run kvm guests on IA64

[Zhang, Xiantao]

>> 4. Insert kvm.ko kvm-intel.ko to kernel.
> 
> kvm-intel is the name of the module fox x86-intel. Do we have a
> collision here? Or is this supposed to load the x86 one on x86 and
> ia64 one on  ia64? 
> 
> OK, I just saw your patches for Kconfig and Makefiles and we use
> CONFIG_KVM_INTEL for ia64 as well as x86. We should separate out
> these two before we run into troubles.


It shouldn't have any confilicts, since they belong to different archs.
Currently, you know source code is placed at arch/{$arch}/kvm, and
Makefile and Kconfig aslo there. 
So, it doesn't impact any issues, since ia64 and x86_64 are totally
different archs.  For example, you can define HAS_IO_PORT macro for ia64
and x86, but they don't invoke any conficlts.:)

>> Userspace built:
>> 
>> 1. Download kvm-userspace source.
>> 2. ./configure
> 
> ./configure --with-patched-kernel in case you want to use the modules
> from the kernel that was built as mentioned above.

>> 3. cd kernel
>> 4. make sync LINUX= "Your kvm kernel source directory."
> 
> This step isn't needed if you build and install the kernel and plan
> to use the same modules. This is only needed if you want to upgrade
> kvm without upgrading the kernel or rebooting.

I think it should be necessary, since some common header files are need
to sync to userspace, such as kvm.h, kvm_para.h :)

Xiantao

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: README: How to run kvm guests on IA64

[Amit Shah]

On Thursday 27 December 2007 08:00:49 Zhang, Xiantao wrote:
> >> 4. Insert kvm.ko kvm-intel.ko to kernel.
> >
> > kvm-intel is the name of the module fox x86-intel. Do we have a
> > collision here? Or is this supposed to load the x86 one on x86 and
> > ia64 one on  ia64?
> >
> > OK, I just saw your patches for Kconfig and Makefiles and we use
> > CONFIG_KVM_INTEL for ia64 as well as x86. We should separate out
> > these two before we run into troubles.
>
> It shouldn't have any confilicts, since they belong to different archs.
> Currently, you know source code is placed at arch/{$arch}/kvm, and
> Makefile and Kconfig aslo there.
> So, it doesn't impact any issues, since ia64 and x86_64 are totally
> different archs.  For example, you can define HAS_IO_PORT macro for ia64
> and x86, but they don't invoke any conficlts.:)

What about files that get shared?

> >> Userspace built:
> >>
> >> 1. Download kvm-userspace source.
> >> 2. ./configure
> >
> > ./configure --with-patched-kernel in case you want to use the modules
> > from the kernel that was built as mentioned above.
> >
> >> 3. cd kernel
> >> 4. make sync LINUX= "Your kvm kernel source directory."
> >
> > This step isn't needed if you build and install the kernel and plan
> > to use the same modules. This is only needed if you want to upgrade
> > kvm without upgrading the kernel or rebooting.
>
> I think it should be necessary, since some common header files are need
> to sync to userspace, such as kvm.h, kvm_para.h :)

The build system should pick up the relevant files 
from /lib/modules/`uname -r`/build/ If it doesn't, it's a bug. (It works for 
me on x86.)

>
> Xiantao

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: README: How to run kvm guests on IA64

[Zhang, Xiantao]

>> It shouldn't have any confilicts, since they belong to different
>> archs. Currently, you know source code is placed at
>> arch/{$arch}/kvm, and Makefile and Kconfig aslo there.
>> So, it doesn't impact any issues, since ia64 and x86_64 are totally
>> different archs.  For example, you can define HAS_IO_PORT macro for
>> ia64 and x86, but they don't invoke any conficlts.:)
> 
> What about files that get shared?

I think common files shouldn't use KVM_CONFIG_INTEL.


> The build system should pick up the relevant files
> from /lib/modules/`uname -r`/build/ If it doesn't, it's a bug. (It
> works for me on x86.)

If we built on target machine,  you are right. But if the build machine
is not target machine, how to build ?

Xiantao


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: README: How to run kvm guests on IA64

[Amit Shah]

On Thursday 27 December 2007 13:20:06 Zhang, Xiantao wrote:
> >> It shouldn't have any confilicts, since they belong to different
> >> archs. Currently, you know source code is placed at
> >> arch/{$arch}/kvm, and Makefile and Kconfig aslo there.
> >> So, it doesn't impact any issues, since ia64 and x86_64 are totally
> >> different archs.  For example, you can define HAS_IO_PORT macro for
> >> ia64 and x86, but they don't invoke any conficlts.:)
> >
> > What about files that get shared?
>
> I think common files shouldn't use KVM_CONFIG_INTEL.

Even then I'm not sure we should use a common #define within the sources that 
will apply to two different architectures in different ways under different 
build environments. Avi, what do you think?

> > The build system should pick up the relevant files
> > from /lib/modules/`uname -r`/build/ If it doesn't, it's a bug. (It
> > works for me on x86.)
>
> If we built on target machine,  you are right. But if the build machine
> is not target machine, how to build ?

We can use the --kerneldir option in that case. However, this might be too 
much info (and very confusing) for a basic README.

>
> Xiantao

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: README: How to run kvm guests on IA64

[Avi Kivity]

Amit Shah wrote:
> On Thursday 27 December 2007 13:20:06 Zhang, Xiantao wrote:
>   
>>>> It shouldn't have any confilicts, since they belong to different
>>>> archs. Currently, you know source code is placed at
>>>> arch/{$arch}/kvm, and Makefile and Kconfig aslo there.
>>>> So, it doesn't impact any issues, since ia64 and x86_64 are totally
>>>> different archs.  For example, you can define HAS_IO_PORT macro for
>>>> ia64 and x86, but they don't invoke any conficlts.:)
>>>>         
>>> What about files that get shared?
>>>       
>> I think common files shouldn't use KVM_CONFIG_INTEL.
>>     
>
> Even then I'm not sure we should use a common #define within the sources that 
> will apply to two different architectures in different ways under different 
> build environments. Avi, what do you think?
>   

I agree in principle, but I don't see a big hurry to change things.  
Let's get it merged first.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/