From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Carlo Marcelo Arenas Belon
<carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] libkvm: fix mungled default case for switch in kvm_arch_run
Date: Sun, 30 Dec 2007 14:29:49 +0200 [thread overview]
Message-ID: <47778F3D.5030100@qumranet.com> (raw)
In-Reply-To: <20071228042930.GA22639@tapir>
Carlo Marcelo Arenas Belon wrote:
> This patch corrects 03f1b5e137e7e4c8dd51dbaea6779be853f4fde0, that
> modified the logic behind kvm_arch_run because of a mangled endif
> which accidentally included the default entry for the switch.
>
> kvm_arch_run as defined in 4f19bdea03330641fd48514ea84d1ed1bf431507
> was affected by returning 0 by default instead of 1 and reporting
> the following warning at compile time :
>
> libkvm-x86.c:201:9: warning: extra tokens at end of #endif directive
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2007-12-30 12:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-28 4:29 [PATCH] libkvm: fix mungled default case for switch in kvm_arch_run Carlo Marcelo Arenas Belon
2007-12-30 12:29 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47778F3D.5030100@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox