* [PATCH] libkvm: fix mungled default case for switch in kvm_arch_run
@ 2007-12-28 4:29 Carlo Marcelo Arenas Belon
2007-12-30 12:29 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Carlo Marcelo Arenas Belon @ 2007-12-28 4:29 UTC (permalink / raw)
To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
This patch corrects 03f1b5e137e7e4c8dd51dbaea6779be853f4fde0, that
modified the logic behind kvm_arch_run because of a mangled endif
which accidentally included the default entry for the switch.
kvm_arch_run as defined in 4f19bdea03330641fd48514ea84d1ed1bf431507
was affected by returning 0 by default instead of 1 and reporting
the following warning at compile time :
libkvm-x86.c:201:9: warning: extra tokens at end of #endif directive
Signed-off-by: Carlo Marcelo Arenas Belon <carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
---
libkvm/libkvm-x86.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/libkvm/libkvm-x86.c b/libkvm/libkvm-x86.c
index e6eb66e..2fa8146 100644
--- a/libkvm/libkvm-x86.c
+++ b/libkvm/libkvm-x86.c
@@ -198,7 +198,8 @@ int kvm_arch_run(struct kvm_run *run,kvm_context_t kvm, int vcpu)
case KVM_EXIT_TPR_ACCESS:
r = handle_tpr_access(kvm, run, vcpu);
break;
-#endif default:
+#endif
+ default:
r = 1;
break;
}
--
1.5.2.5
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libkvm: fix mungled default case for switch in kvm_arch_run
2007-12-28 4:29 [PATCH] libkvm: fix mungled default case for switch in kvm_arch_run Carlo Marcelo Arenas Belon
@ 2007-12-30 12:29 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2007-12-30 12:29 UTC (permalink / raw)
To: Carlo Marcelo Arenas Belon; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
Carlo Marcelo Arenas Belon wrote:
> This patch corrects 03f1b5e137e7e4c8dd51dbaea6779be853f4fde0, that
> modified the logic behind kvm_arch_run because of a mangled endif
> which accidentally included the default entry for the switch.
>
> kvm_arch_run as defined in 4f19bdea03330641fd48514ea84d1ed1bf431507
> was affected by returning 0 by default instead of 1 and reporting
> the following warning at compile time :
>
> libkvm-x86.c:201:9: warning: extra tokens at end of #endif directive
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-30 12:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-28 4:29 [PATCH] libkvm: fix mungled default case for switch in kvm_arch_run Carlo Marcelo Arenas Belon
2007-12-30 12:29 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox