From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/4] KVM: MMU: Concurrent guest walkers Date: Sun, 30 Dec 2007 16:39:42 +0200 Message-ID: <4777ADAE.4010308@qumranet.com> References: <1199013439-2047-1-git-send-email-avi@qumranet.com> <1199013439-2047-2-git-send-email-avi@qumranet.com> <47779CF8.1000408@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: In-Reply-To: <47779CF8.1000408-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > Avi Kivity wrote: >> From: Marcelo Tosatti >> >> Do not hold kvm->lock mutex across the entire pagefault code, >> only acquire it in places where it is necessary, such as mmu >> hash list, active list, rmap and parent pte handling. >> >> Allow concurrent guest walkers by switching walk_addr() to use >> mmap_sem in read-mode. >> >> And get rid of the lockless __gfn_to_page. >> >> [avi: move kvm_mmu_pte_write() locking inside the function] >> [avi: add locking for real mode] >> >> > > Something's wrong here, since with this patch applied I get soft > lockups running FC6 x86_64. Wierd since apic accesses are per-vcpu > and so the locking (even if wrong) should not matter. > This goes away if lockstats are disabled, so it is probably an artifact. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/