public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel
	<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	virtualization
	<virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [Virtio-for-kvm] [PATCH 7/7] userspace virtio
Date: Wed, 02 Jan 2008 19:22:27 +0200	[thread overview]
Message-ID: <477BC853.405@qumranet.com> (raw)
In-Reply-To: <477BB5D2.6010304-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Anthony Liguori wrote:
> I think we should hold off on this sort of patch at first.  I know it 
> improves performance, but it's very hack-ish.  I have a similar patch[1] 
> that improves performance more but is even more hack-ish.
>
> I think we have to approach this by not special cases virtio-net to know 
> about the tap fd, but to figure out the interface that virtio-net would 
> need to be efficient, and then refactor the net interface to look like 
> that.  Then we can still support user, pcap, and the other network 
> transports.
>
> [1] http://hg.codemonkey.ws/qemu-virtio/file/75cefe566cea/aio-net.diff
>   

While you are right in principle, high performance networking is long 
overdue in kvm so I applied that patch.  Once a mega async dma framework 
is added to qemu, we'll just revert that patch prior to adding the glue 
to said framework.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2008-01-02 17:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-21 14:46 [Virtio-for-kvm] [PATCH 7/7] userspace virtio Dor Laor
     [not found] ` <476BD1A9.2040701-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-12-23 10:56   ` Avi Kivity
2008-01-02 16:03   ` Anthony Liguori
     [not found]     ` <477BB5D2.6010304-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-01-02 17:22       ` Avi Kivity [this message]
     [not found]         ` <477BC853.405-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-02 21:45           ` Dor Laor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=477BC853.405@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox